Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Migrate SelectInterval/SelectSeverity unit tests from enzyme to react-testing-lib #153321

Merged
merged 7 commits into from
Mar 23, 2023
Merged

[ML] Migrate SelectInterval/SelectSeverity unit tests from enzyme to react-testing-lib #153321

merged 7 commits into from
Mar 23, 2023

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Mar 20, 2023 •
edited
Loading

Summary

Part of #153288.

Migrates the following React component tests from enzyme to react-testing-lib.

  • SelectInterval
  • SelectSeverity

Checklist

@walterra walterra self-assigned this Mar 20, 2023
@walterra walterra marked this pull request as ready for review March 21, 2023 15:11
@walterra walterra requested a review from a team as a code owner March 21, 2023 15:11
@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels Mar 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra mentioned this pull request Mar 21, 2023
Open
33 tasks
jgowdyelastic
jgowdyelastic approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@walterra walterra changed the title [ML] Migrate from enzyme to react-testing-lib [ML] Migrate SelectInterval/SelectSeverity unit tests from enzyme to react-testing-lib Mar 22, 2023
darnautov
darnautov approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple of minor suggestions

...k/plugins/ml/public/application/components/controls/select_interval/select_interval.test.tsx Outdated Show resolved Hide resolved
...k/plugins/ml/public/application/components/controls/select_severity/select_severity.test.tsx Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB +2.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit 83ec37f into elastic:main Mar 23, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 23, 2023
@walterra walterra deleted the ml-153288-1-enzyme branch March 23, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting :ml refactoring release_note:skip Skip the PR/issue when compiling release notes v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @kibana-ci @darnautov @jgowdyelastic @kibanamachine