[data views] Implement content management api #153733
Conversation
mattkime
changed the title
| return response.map<SavedObject<T>>(simpleSavedObjectToSavedObject); | ||
| async find(options: SavedObjectsClientCommonFindArgs) { | ||
| console.log('******* find', options); | ||
| const results = await this.contentManagemntClient.search<DataViewSearchIn, DataViewSearchOut>({ |
There was a problem hiding this comment.
@sebelga I must be doing something wrong here.
There was a problem hiding this comment.
You need to pass an object for the query.
Add an empty object if you don't need any parameters
const results = await this.contentManagemntClient.search<DataViewSearchIn, DataViewSearchOut>({
contentTypeId: 'index-pattern',
query: {},
});
| export type DataViewCreateIn = CreateIn< | ||
| typeof DataViewContentType, | ||
| DataViewAttributes, | ||
| CreateOptions |
There was a problem hiding this comment.
You are explicitely declaring that DataViewCreateIn takes CreateOptions. You now have to pass it in saved_objects_client_wrapper.ts L91
| return (await this.contentManagemntClient.create<DataViewCreateIn, DataViewCreateOut>({ | ||
| contentTypeId: 'index-pattern', | ||
| data: attributes, | ||
| // this is required, shouldn't be. |
…into data_views_content_mgmt
mattkime
changed the title
| @@ -14,7 +14,6 @@ | |||
| "@kbn/object-versioning", | |||
| "@kbn/core-saved-objects-api-server-mocks", | |||
| "@kbn/core-saved-objects-api-server", | |||
| "@kbn/saved-objects-finder-plugin", | |||
There was a problem hiding this comment.
This was necessary to remove a circular dependency.
mattkime
added
Feature:Data Views
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
| return savedObjects.client; | ||
| }; | ||
|
|
||
| export class DataViewsStorage implements ContentStorage { |
There was a problem hiding this comment.
@sebelga This would be my starting point for abstracting ContentStorage for use with Saved Objects. Is there anything in particular that I should keep an eye on regarding the Maps implementation? It currently has versioning code so I'd like to make sure I we're on the same page regarding what the end product should look like.
There was a problem hiding this comment.
Overall looks good. You would probably need to add all the BWC logic for up/down transform + validate the inputs/outputs.
You would also need to implement the bulkGet method.
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
| perPage: query.limit, | ||
| page: query.cursor ? +query.cursor : undefined, | ||
| defaultSearchOperator: 'AND', | ||
| searchFields: options.searchFields || ['title', 'name'], |
There was a problem hiding this comment.
You are exposing searching accross any fields on the database from the UI. It is better to limit what fields can be searched on.
In maps I added an onlyTitle option to avoid that (https://github.com/elastic/kibana/pull/153304/files#diff-3196f0787529ecacf22f90a6081b048f25eb3cf980b548437da12df2879ccdadR287).
|
@jughosta You're correct, this isn't quite ready for review. |
|
I guess this can be closed in favor of #155803? |
|
thx! |
Summary
Data views implementation of content management api.
This PR includes the changes in #154985 which should be merged first.