Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[content management] visualizations #153764

Merged
merged 4 commits into from
May 4, 2023

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Mar 27, 2023

Summary

Fixes #154439

Registers Visualize Content to Content Management Service and uses new client instead of saved objects client in the browser.

Checklist

@ppisljar ppisljar force-pushed the visualize/content-management branch from ab96563 to 09a5ab6 Compare March 27, 2023 14:28
@ppisljar ppisljar force-pushed the visualize/content-management branch 5 times, most recently from 549e132 to 49c174b Compare April 13, 2023 16:22
@ppisljar ppisljar force-pushed the visualize/content-management branch 5 times, most recently from 9a3792d to 275caff Compare April 25, 2023 10:22
@ppisljar ppisljar force-pushed the visualize/content-management branch from 275caff to ff73429 Compare April 25, 2023 11:39
@ppisljar ppisljar marked this pull request as ready for review April 25, 2023 12:44
@ppisljar ppisljar requested a review from a team as a code owner April 25, 2023 12:44
@ppisljar ppisljar added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Apr 25, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally 👍

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 3, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #58 / dashboard app - group 1 edit embeddable redirects redirects via save as button after edit, renaming itself
  • [job] [logs] FTR Configs #58 / dashboard app - group 1 edit embeddable redirects redirects via save as button after edit, renaming itself

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visualizations 332 337 +5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
visualizations 770 775 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 260.4KB 260.2KB -281.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
visualizations 18 19 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visualizations 57.3KB 58.0KB +763.0B
Unknown metric groups

API count

id before after diff
visualizations 800 805 +5

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
visualizations 15 16 +1
total +6

References to deprecated APIs

id before after diff
visualizations 127 55 -72

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
visualizations 17 18 +1
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar merged commit d591cab into elastic:main May 4, 2023
@thomasneirynck
Copy link
Contributor

Part of #157043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Visualizations] Migrate the SOs to content management
6 participants