Fixes KQL autocomplete suggestions with IP fields #154111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
release_note:fix
Feature:KQL
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
stratoula
approved these changes
Mar 31, 2023
jughosta
approved these changes
Mar 31, 2023
Comment on lines
102
to
103
| const [field] = stubFields.filter( | ||
| ({ type, aggregatable }) => type === 'string' && aggregatable | ||
| ({ type, aggregatable }) => (type === 'string' || type === 'ip') && aggregatable |
There was a problem hiding this comment.
Would it be helpful to also call await getValueSuggestions({...}) separately for a string field and for an ip field then? And check that http.fetch was called twice.
There was a problem hiding this comment.
Addressed in 0e2c81f.
Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com>
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @lukasolson |
1 task
|
Thank you so much @lukasolson ! Just a comment for future readers: |
danielmitterdorfer
added a commit
that referenced
this pull request
Apr 20, 2023
nikitaindik
pushed a commit
to nikitaindik/kibana
that referenced
this pull request
Apr 25, 2023
Previously we had mapped host ips as keywords as well as ips in order to work around elastic#140266. This has been fixed with elastic#154111 so we can rely on the IP field and remove the duplicate. Relates elastic#154111 Relates elastic#140266
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #140266.
Fixes KQL autocomplete suggestions when using an IP field. (Only works when the selected value suggestion method is terms_enum, not terms_agg.)
Checklist
Release note
KQL autocomplete suggestions now support IP-type fields when the advanced setting, autocomplete:valueSuggestionMethod, is set to terms_enum.