Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Mapping cleanup for Signals Migration Saved Object #154949

Merged
merged 8 commits into from
Apr 20, 2023

Commits on Apr 13, 2023

  1. Remove nonindexed mappings(?) from Signals Migration SO

    These fields are captured in schema elsewhere (and validated there as
    well).
    
    This effort is part of @elastic/security-teamelastic#6268.
    rylnd committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    d8bc31d View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Configuration menu
    Copy the full SHA
    05a0d0a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ed16e4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0ccbb0f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0900808 View commit details
    Browse the repository at this point in the history
  5. Adds back a necessary date field

    After deleting this field, test failures reminded me that we use this as
    a sortField when checking the migration status, so we need the field in
    some capacity.
    
    This previously worked despite the field being `index: false` because
    elasticsearch is able to sort on doc_values
    (https://www.elastic.co/guide/en/elasticsearch/reference/current/doc-values.html)
    
    However, in order to make this sorting more efficient, and because we'll
    never be able to remove `index: false` moving forward, I'm removing it
    here. This implicitly adds a mapping for this field.
    rylnd committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    008d5c4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    aac029d View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Configuration menu
    Copy the full SHA
    811c21a View commit details
    Browse the repository at this point in the history