Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] [CNVM] Fixed vulnerabilities transform unique key #155206

Merged
merged 3 commits into from
Apr 19, 2023
Merged

[Cloud Security] [CNVM] Fixed vulnerabilities transform unique key #155206

merged 3 commits into from
Apr 19, 2023

Conversation

kfirpeled
Copy link
Contributor

@kfirpeled kfirpeled commented Apr 18, 2023 •
edited
Loading

Summary

We previously calculated unique key for vulnerability on the wrong key.
Fixed from package.version to vulnerability.package.version

@kfirpeled kfirpeled added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related labels Apr 18, 2023
@kfirpeled kfirpeled requested a review from a team as a code owner April 18, 2023 21:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kfirpeled kfirpeled linked an issue Apr 18, 2023 that may be closed by this pull request
[Cloud Security] [CNVM] transform cuts off plenty of documents and views partial #155205
Closed
kfirpeled
kfirpeled commented Apr 19, 2023
View reviewed changes
Copy link
Contributor Author

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added package name to uniqueness key

@kfirpeled kfirpeled enabled auto-merge (squash) April 19, 2023 22:41
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kfirpeled kfirpeled merged commit 80fb939 into elastic:main Apr 19, 2023
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Apr 19, 2023
nikitaindik pushed a commit to nikitaindik/kibana that referenced this pull request Apr 25, 2023
@kfirpeled @nikitaindik
[Cloud Security] [CNVM] Fixed vulnerabilities transform unique key (e…
412bd6e 
…lastic#155206)
@Omolola-Akinleye Omolola-Akinleye mentioned this pull request May 1, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opauloh opauloh opauloh approved these changes

@jeniawhite jeniawhite Awaiting requested review from jeniawhite

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud Security] [CNVM] transform cuts off plenty of documents and views partial
5 participants
@kfirpeled @elasticmachine @kibana-ci @opauloh @kibanamachine