Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Add active maintenance window callout to the Rules Management page #155386

Merged
merged 23 commits into from
Apr 24, 2023
Merged

[Security Solution] Add active maintenance window callout to the Rules Management page #155386

merged 23 commits into from
Apr 24, 2023

Commits on Apr 21, 2023

  1. Fetch currently running MWs

    @nikitaindik
    nikitaindik committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    3b1199f View commit details
    Browse the repository at this point in the history

  2. Add tests

    @nikitaindik
    nikitaindik committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    9d3d956 View commit details
    Browse the repository at this point in the history

  3. Revert back to ENABLE_MAINTENANCE_WINDOWS=false flag value in Alertin… 

    …g app
    @nikitaindik
    nikitaindik committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    d48d9d0 View commit details
    Browse the repository at this point in the history

  4. Adjust the wording

    @nikitaindik
    nikitaindik committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    f3be8fc View commit details
    Browse the repository at this point in the history

  5. Tweak wording in test to match the changes in code

    @nikitaindik
    nikitaindik committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    3e55fe6 View commit details
    Browse the repository at this point in the history

  6. [CI] Auto-commit changed files from 'node scripts/lint_ts_projects --… 

    …fix'
    @kibanamachine
    kibanamachine committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    8a80c9b View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Merge branch 'main' into maintenance-windows-rule-management

    @nikitaindik
    nikitaindik committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    415a3a2 View commit details
    Browse the repository at this point in the history

  2. Move API path constant to Alerting plugin

    @nikitaindik
    nikitaindik committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    1f70328 View commit details
    Browse the repository at this point in the history

  3. Make Jest test names shorter and more consistent

    @nikitaindik
    nikitaindik committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    5cc23bc View commit details
    Browse the repository at this point in the history

  4. Rewrite MaintenanceWindowCallout to function expression, add return type

    @nikitaindik
    nikitaindik committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    4d5cbd9 View commit details
    Browse the repository at this point in the history

  5. Cy test: Increase MW lifetime to 60 secs to make sure test doesn't be… 

    …come flaky
    @nikitaindik
    nikitaindik committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    35c4de8 View commit details
    Browse the repository at this point in the history

  6. Remove redundant fields in Jest mocks

    @nikitaindik
    nikitaindik committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    08b24a4 View commit details
    Browse the repository at this point in the history

  7. Accept error wording suggestion 

    Co-authored-by: Georgii Gorbachev <banderror@gmail.com>
    @nikitaindik @banderror
    nikitaindik and banderror authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    cf12b62 View commit details
    Browse the repository at this point in the history

  8. Accept callout description wording suggestion 

    Co-authored-by: Georgii Gorbachev <banderror@gmail.com>
    @nikitaindik @banderror
    nikitaindik and banderror authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    afe38bf View commit details
    Browse the repository at this point in the history

  9. Add "as const" to a constant for a better typechecking

    @nikitaindik
    nikitaindik committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    23d738e View commit details
    Browse the repository at this point in the history

  10. Merge branch 'maintenance-windows-rule-management' of github.com:niki… 

    …taindik/kibana into maintenance-windows-rule-management
    @nikitaindik
    nikitaindik committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    be65dae View commit details
    Browse the repository at this point in the history

  11. Types

    @nikitaindik
    nikitaindik committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    bcf49b2 View commit details
    Browse the repository at this point in the history

  12. Accept test title wording suggestion 

    Co-authored-by: Georgii Gorbachev <banderror@gmail.com>
    @nikitaindik @banderror
    nikitaindik and banderror authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    197d88f View commit details
    Browse the repository at this point in the history

  13. Merge branch 'maintenance-windows-rule-management' of github.com:niki… 

    …taindik/kibana into maintenance-windows-rule-management
    @nikitaindik
    nikitaindik committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    e26577e View commit details
    Browse the repository at this point in the history

  14. Jest tests: fix wording, remove network error logging

    @nikitaindik
    nikitaindik committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    32089fe View commit details
    Browse the repository at this point in the history

  15. Add path constants on alerting plugin side, use them in tests

    @nikitaindik
    nikitaindik committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    fdd93c8 View commit details
    Browse the repository at this point in the history

  16. Use .some() instead of .find() to check for 'running' maintenance win… 

    …dows
    @nikitaindik
    nikitaindik committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    3fb0b77 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'main' into maintenance-windows-rule-management

    @nikitaindik
    nikitaindik authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    45b6683 View commit details
    Browse the repository at this point in the history