[Synthetics] Filtering - location filter counts are off when filter is applied #155437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s applied Co-authored-by: Anjola Adeuyi <57623705+anjola-adeuyi@users.noreply.github.com> Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
gitstart
changed the title
shahzad31
added
release_note:skip
|
buildkite test this |
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
approved these changes
Apr 21, 2023
|
buildkite test this |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
@elasticmachine run elasticsearch-ci/docs |
shahzad31
added
v8.7.0
v8.7.2
and removed
backport:skip
shahzad31
added
auto-backport
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
shahzad31
pushed a commit
to shahzad31/kibana
that referenced
this pull request
Apr 21, 2023
…s applied (elastic#155437) Co-authored-by: Anjola Adeuyi <57623705+anjola-adeuyi@users.noreply.github.com> Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com> Co-authored-by: shahzad31 <shahzad31comp@gmail.com> (cherry picked from commit f95ebdf)
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
nikitaindik
pushed a commit
to nikitaindik/kibana
that referenced
this pull request
Apr 25, 2023
…s applied (elastic#155437) Co-authored-by: Anjola Adeuyi <57623705+anjola-adeuyi@users.noreply.github.com> Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com> Co-authored-by: shahzad31 <shahzad31comp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue where the location count appears incorrect when a filter is applied, but is correct when no filter is applied. The issue has been resolved by updating the logic and taking into account the filter when it is applied.
Issue References
Client: #155214
Loom/Screenshot Demo
Screen.Recording.2023-04-20.at.13.40.16.mov
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.