[Cases] Renaming user action type #156113
Conversation
jonathan-buttner
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
| export type CaseUserActionsDeprecatedResponse = rt.TypeOf< | ||
| typeof CaseUserActionsDeprecatedResponseRt | ||
| >; | ||
| export type CaseUserActionDeprecatedResponse = rt.TypeOf<typeof CaseUserActionDeprecatedResponseRt>; | ||
| export type CaseUserActionInjectedAttributes = rt.TypeOf<typeof CaseUserActionInjectedAttributesRt>; | ||
| export type UserActionAttributesWithInjectedId = rt.TypeOf< |
There was a problem hiding this comment.
Maybe we should rename it to UserActionAttributes as we did with CaseAttributes.
| @@ -120,7 +120,7 @@ describe('lifespan', () => { | |||
| [ | |||
| { | |||
| attributes: { payload: { hello: 1, status: CaseStatuses.closed }, type: 'status' }, | |||
| } as unknown as SavedObject<CaseUserActionInjectedAttributes>, | |||
| } as unknown as SavedObject<UserActionAttributesWithInjectedId>, | |||
There was a problem hiding this comment.
Maybe we can create a type export type UserActionSavedObjectTransformed = SavedObject<UserActionTransformedAttributes>;.
There was a problem hiding this comment.
I'm going to leave these as is for now since they're in the client.
| @@ -138,7 +138,7 @@ export function getStatusInfo( | |||
| } | |||
|
|
|||
| function isValidStatusChangeUserAction( | |||
| attributes: CaseUserActionInjectedAttributes, | |||
| attributes: UserActionAttributesWithInjectedId, | |||
There was a problem hiding this comment.
I think we should use UserActionTransformedAttributes.
There was a problem hiding this comment.
We talked about this offline, this will be UserActionAttributes
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
This PR creates a proper
UserActiontype and various attributes types to be used in the service layer of the backend.There shouldn't be any functionality changes here just type name changes.