Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EUI: Reset CSS #2 #15657

Merged
merged 20 commits into from
Dec 19, 2017
Merged

EUI: Reset CSS #2 #15657

merged 20 commits into from
Dec 19, 2017

Commits on Dec 18, 2017

  1. Add EUI v0.0.6 as a dependency. 

    - Add support for using dark theme EUI CSS in Dashboard.
- Set light theme as the default.
- Add comments to chrome.jade about role of theme node.
- Add (WTFPL OR MIT) to acceptable licenses.
    @cjcenizal
    cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    844cacc View commit details
    Browse the repository at this point in the history

  2. Remove old reset CSS. 

    - Remove naked element selectors from base.less.
- Remove Bootstrap resets.
- Remove UI Framework reset.
- Remove unused reset styles from UI Framework.
    @cjcenizal
    cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    bfc5bcd View commit details
    Browse the repository at this point in the history

  3. Fix CSS regressions caused by removal of CSS reset. 

    - Replace usage of sr-only with euiScreenReaderOnly.
- Apply euiButtonEmpty classes to the 'Add a filter' button.
- Fix Notification padding and layout.
- Apply euiTabs styles to Timepicker mode tabs.
- Fix layout of Available Fields heading in Discover.
- Add padding to Popular Fields container in Discover.
- Push down Selected Fields heading in Discover sidebar.
- Fix appearance of links in Discover sidebar.
- Fix height of pills in Filter Bar.
    @cjcenizal
    cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    992fbed View commit details
    Browse the repository at this point in the history

  4. EUI css reset fixes 

    Small css fixes to adress reset changes with the introduction of EUI.
    @snide @cjcenizal
    snide authored and cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    49ae650 View commit details
    Browse the repository at this point in the history

  5. Label fix for EUI regression (#15605) 

    Small fix for checkbox spacing due to EUI reset.
    @snide @cjcenizal
    snide authored and cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    fa4de14 View commit details
    Browse the repository at this point in the history

  6. Fix timepicker tests. 

    - Remove kbn-accessible-click from timepicker buttons.
    @cjcenizal
    cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    030771f View commit details
    Browse the repository at this point in the history

  7. Set quiet temporarily to false.

    @cjcenizal
    cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    6f53bc7 View commit details
    Browse the repository at this point in the history

  8. Experiment: downgrade to 0.0.5 to see if tests pass.

    @cjcenizal
    cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    3c6b6c6 View commit details
    Browse the repository at this point in the history

  9. Experiment: downgrade to 0.0.3 to see if tests pass.

    @cjcenizal
    cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    c7f7cf3 View commit details
    Browse the repository at this point in the history

  10. Revert "EUI css reset fixes" 

    This reverts commit 49ae650.
    @cjcenizal
    cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    44b0c25 View commit details
    Browse the repository at this point in the history

  11. Use byCssSelector inside of testSubjects.find.

    @cjcenizal
    cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    2d88459 View commit details
    Browse the repository at this point in the history

  12. Delete flaky view_edit.js test: 'when time changed is stored with das… 

    …hboard'.
    @cjcenizal
    cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    c756d52 View commit details
    Browse the repository at this point in the history

  13. Upgrade EUI back to v0.0.6.

    @cjcenizal
    cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    e221df6 View commit details
    Browse the repository at this point in the history

  14. Delete flaky view_edit.js test: 'and preserves edits on cancel > when… 

    … time changed is stored with dashboard'.
    @chrisronline
    chrisronline committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    3baf18a View commit details
    Browse the repository at this point in the history

  15. Add all dashboard tests back in

    @chrisronline
    chrisronline committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    11c085b View commit details
    Browse the repository at this point in the history

  16. Bring back all functional tests

    @chrisronline
    chrisronline committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    6cc3b04 View commit details
    Browse the repository at this point in the history

  17. Fix linting issue

    @chrisronline
    chrisronline committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    35edbdd View commit details
    Browse the repository at this point in the history

  18. Upgrade EUI to 0.0.7.

    @cjcenizal
    cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    73c7a38 View commit details
    Browse the repository at this point in the history

  19. Delete flake Gauge Chart tests. EUI changed the font size, and the te… 

    …xt within the gauges doesn't render when the window is too small.
    @cjcenizal
    cjcenizal committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    ac727ed View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2017

  1. Revert "Set quiet temporarily to false." 

    This reverts commit 6f53bc7.
    @cjcenizal
    cjcenizal committed Dec 19, 2017
    Configuration menu
    Copy the full SHA
    52e5ee8 View commit details
    Browse the repository at this point in the history