Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Explicitly mapping user action SOs attributes #156584

Closed
wants to merge 5 commits into from

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented May 3, 2023

Summary

This PR maps the SO attributes explicitly when returning a user action SO from within the user services.

For maintainers

@cnasikas cnasikas added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.9.0 labels May 3, 2023
@cnasikas cnasikas self-assigned this May 3, 2023
@cnasikas cnasikas requested a review from a team as a code owner May 3, 2023 16:24
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

References to deprecated APIs

id before after diff
cases 59 13 -46

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@@ -145,9 +175,13 @@ const addReferenceIdToPayload = (
);

return {
...userAction.attributes.payload,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be also explicitly mapped?

@cnasikas
Copy link
Member Author

Closing in favor of #157971

@cnasikas cnasikas closed this May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants