Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Change truncated 'run action every' to visible 'run every' #156753

Merged
merged 1 commit into from
May 22, 2023
Merged

[RAM] Change truncated 'run action every' to visible 'run every' #156753

merged 1 commit into from
May 22, 2023

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented May 4, 2023 •
edited by kibanamachine
Loading

Summary

#155804 introduced this bug:

Screenshot 2023-05-04 at 3 43 05 PM

After:

Screenshot 2023-05-04 at 3 45 09 PM

@Zacqary Zacqary requested a review from a team as a code owner May 4, 2023 20:46
@Zacqary Zacqary added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label May 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #3 / timeline flyout button the (+) button popover menu owns focus

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.4MB 1.4MB -7.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary merged commit 8a9fb98 into elastic:main May 22, 2023
@kibanamachine kibanamachine mentioned this pull request May 22, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 22, 2023
@Zacqary
[RAM] Change truncated 'run action every' to visible 'run every' (ela…
376c7c0 
…stic#156753)

## Summary

elastic#155804 introduced this bug:

<img width="568" alt="Screenshot 2023-05-04 at 3 43 05 PM"
src="https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png">

After:

<img width="562" alt="Screenshot 2023-05-04 at 3 45 09 PM"
src="https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png">

(cherry picked from commit 8a9fb98)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 22, 2023
@kibanamachine @Zacqary
[8.8] [RAM] Change truncated 'run action every' to visible 'run every' (
cfef093 
#156753) (#158206)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[RAM] Change truncated 'run action every' to visible 'run every'
(#156753)](#156753)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Zacqary Adam
Xeper","email":"Zacqary@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-22T16:29:02Z","message":"[RAM]
Change truncated 'run action every' to visible 'run every'
(#156753)\n\n## Summary\r\n\r\n#155804 introduced this bug:\r\n\r\n<img
width=\"568\" alt=\"Screenshot 2023-05-04 at 3 43 05
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png\">\r\n\r\n\r\nAfter:\r\n\r\n<img
width=\"562\" alt=\"Screenshot 2023-05-04 at 3 45 09
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png\">","sha":"8a9fb98c757dd24f1efccd590b6f86640888dee7","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","Feature:Alerting/RulesManagement","v8.9.0","v8.8.1"],"number":156753,"url":"https://github.com/elastic/kibana/pull/156753","mergeCommit":{"message":"[RAM]
Change truncated 'run action every' to visible 'run every'
(#156753)\n\n## Summary\r\n\r\n#155804 introduced this bug:\r\n\r\n<img
width=\"568\" alt=\"Screenshot 2023-05-04 at 3 43 05
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png\">\r\n\r\n\r\nAfter:\r\n\r\n<img
width=\"562\" alt=\"Screenshot 2023-05-04 at 3 45 09
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png\">","sha":"8a9fb98c757dd24f1efccd590b6f86640888dee7"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156753","number":156753,"mergeCommit":{"message":"[RAM]
Change truncated 'run action every' to visible 'run every'
(#156753)\n\n## Summary\r\n\r\n#155804 introduced this bug:\r\n\r\n<img
width=\"568\" alt=\"Screenshot 2023-05-04 at 3 43 05
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png\">\r\n\r\n\r\nAfter:\r\n\r\n<img
width=\"562\" alt=\"Screenshot 2023-05-04 at 3 45 09
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png\">","sha":"8a9fb98c757dd24f1efccd590b6f86640888dee7"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Zacqary Adam Xeper <Zacqary@users.noreply.github.com>
@lcawl lcawl mentioned this pull request May 24, 2023
Merged
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
@Zacqary @delanni
[RAM] Change truncated 'run action every' to visible 'run every' (ela…
3355148 
…stic#156753)

## Summary

elastic#155804 introduced this bug:

<img width="568" alt="Screenshot 2023-05-04 at 3 43 05 PM"
src="https://user-images.githubusercontent.com/1445834/236325207-6ba7ba7d-c056-4444-9cf4-f3e6287c271b.png">


After:

<img width="562" alt="Screenshot 2023-05-04 at 3 45 09 PM"
src="https://user-images.githubusercontent.com/1445834/236325256-34926a1a-8630-469f-8bdc-01f375648779.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcger jcger jcger approved these changes

Assignees
No one assigned
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 v8.8.1 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Zacqary @elasticmachine @apmmachine @kibana-ci @kibanamachine @jcger