Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps] [Maintenance Windows] Fix date format on the table #156857

Merged
merged 1 commit into from
May 15, 2023

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented May 5, 2023

Resolves #156852

Summary

Removes 24-clock date formatting

Checklist

@doakalexi doakalexi changed the title Fixing date format [ResponseOps] [Maintenance Windows] Fix date format on the table May 5, 2023
@doakalexi doakalexi added bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 v8.9.0 release_note:skip Skip the PR/issue when compiling release notes labels May 5, 2023
@doakalexi doakalexi marked this pull request as ready for review May 5, 2023 14:02
@doakalexi doakalexi requested a review from a team as a code owner May 5, 2023 14:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doakalexi doakalexi merged commit d4877dc into elastic:main May 15, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 15, 2023
…stic#156857)

Resolves elastic#156852

## Summary

Removes 24-clock date formatting

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit d4877dc)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 15, 2023
#156857) (#157743)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[ResponseOps] [Maintenance Windows] Fix date format on the table
(#156857)](#156857)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexi
Doak","email":"109488926+doakalexi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-05-15T14:53:31Z","message":"[ResponseOps]
[Maintenance Windows] Fix date format on the table (#156857)\n\nResolves
#156852
Summary\r\n\r\nRemoves 24-clock date formatting\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"d4877dc5f25280909755542af72cea02e8a8343f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","v8.8.0","v8.9.0"],"number":156857,"url":"#156857
[Maintenance Windows] Fix date format on the table (#156857)\n\nResolves
#156852
Summary\r\n\r\nRemoves 24-clock date formatting\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"d4877dc5f25280909755542af72cea02e8a8343f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#156857
[Maintenance Windows] Fix date format on the table (#156857)\n\nResolves
#156852
Summary\r\n\r\nRemoves 24-clock date formatting\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"d4877dc5f25280909755542af72cea02e8a8343f"}}]}]
BACKPORT-->

Co-authored-by: Alexi Doak <109488926+doakalexi@users.noreply.github.com>
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
…6857)

Resolves #156852

## Summary

Removes 24-clock date formatting

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ResponseOps] [Maintenance Windows] Fix date format on the table
5 participants