[Logs onboarding] Added Cypress to observability onboarding plugin #157147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
yngrdyn
added
the
release_note:skip
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
ogupte
approved these changes
May 10, 2023
| @@ -0,0 +1,3 @@ | |||
| xpack.observability_onboarding.ui.enabled: true | |||
|
|
|||
| xpack.cloud.id: 'foo' | |||
There was a problem hiding this comment.
We should probably set the cloud id value to something that matches the expected format
Example: eastus2.azure.elastic-cloud.com:9243$59ef636c6917463db140321484d63cfa$a8b109c08adc43279ef48f29af1a3911
We may need to decode this id to get the ES deployment when we generate the elastic-agent.yml
sorenlouv
reviewed
May 10, 2023
| }); | ||
|
|
||
| process.exitCode = exitStatus; | ||
| console.log(`Quitting with exit code ${exitStatus}`); |
There was a problem hiding this comment.
This script has caused some confusion in APM so I'm not sure it's the best approach. But if it works for you feel free to carry it over.
sorenlouv
approved these changes
May 10, 2023
kibanamachine
added
v8.9.0
backport:skip
yngrdyn
added a commit
that referenced
this pull request
May 15, 2023
This Pr is a follow up of [PR#157008](#157008) and [PR#157147](#157147). Changes: 1. Replaced usage of `euiThemeVars` by `useEuiTheme` and `useEuiFontSize`. 2. e2e cloudId following [cloud plugin format](https://github.com/elastic/kibana/tree/main/x-pack/plugins/cloud#cloudid).
jasonrhodes
pushed a commit
that referenced
this pull request
May 17, 2023
This Pr is a follow up of [PR#157008](#157008) and [PR#157147](#157147). Changes: 1. Replaced usage of `euiThemeVars` by `useEuiTheme` and `useEuiFontSize`. 2. e2e cloudId following [cloud plugin format](https://github.com/elastic/kibana/tree/main/x-pack/plugins/cloud#cloudid).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables cypress testing in observability onboarding plugin.