Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Remove stale skipped test suite #157728

Merged
merged 2 commits into from
May 15, 2023

Conversation

oatkiller
Copy link
Contributor

Summary

This test has been skipped for 3 years and no specific team owns it.

For maintainers

@oatkiller oatkiller requested a review from a team as a code owner May 15, 2023 13:51
@oatkiller oatkiller added the release_note:skip Skip the PR/issue when compiling release notes label May 15, 2023
@oatkiller oatkiller requested review from a team, patrykkopycinski and gergoabraham and removed request for a team May 15, 2023 14:09
@oatkiller oatkiller requested a review from a team as a code owner May 15, 2023 15:56
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@oatkiller oatkiller changed the title [Security] This test has been skipped for 3 years [Security] Remove stale skipped test suite May 15, 2023
@oatkiller
Copy link
Contributor Author

@elastic/kibana-operations I am working to assign specific areas as codeowners for all the automated tests owned by Security. During my audit, I came across this test suite which has been skipped for 3 years and who has no team owning it. When I removed the test suite, the build failed. I removed the reference from .buildkite/ftr_configs.yml and the build passed. I am guessing that this is the right step. Any guidance (or approval) is appreciated :)

@oatkiller
Copy link
Contributor Author

@paul-tavares I believe your team might have been the original maintainer of this test. Just giving you a heads up.

@oatkiller oatkiller merged commit 456ca02 into elastic:main May 15, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 15, 2023
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
## Summary

This test has been skipped for 3 years and no specific team owns it.

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants