Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Task Manager] stop spamming the logs on status changes #157762

Merged
merged 1 commit into from
May 15, 2023
Merged

[ResponseOps][Task Manager] stop spamming the logs on status changes #157762

merged 1 commit into from
May 15, 2023

Conversation

pmuellr
Copy link
Member

@pmuellr pmuellr commented May 15, 2023 •
edited by kibanamachine
Loading

resolves #156112

Change task manager logging on status errors from warn to debug. Making this change as we recently changed from debugtowarn` in #154045 . But this ended up too noisy, especially at Kibana startup.

@pmuellr
[ResponseOps][Task Manager] stop spamming the logs on status changes
7f8aacd 
resolves elastic#156112

Change task manager logging on status errors from `warn` to `debug.
Making this change as we recently changed from `debug` to `warn`
in elastic#154045 .  But this ended
up too noisy, especially at Kibana startup.
@pmuellr pmuellr added release_note:skip Skip the PR/issue when compiling release notes Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels May 15, 2023
@pmuellr pmuellr marked this pull request as ready for review May 15, 2023 16:01
@pmuellr pmuellr requested a review from a team as a code owner May 15, 2023 16:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

ymao1
ymao1 approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Detection rules, machine learning Creates and enables a new ml rule
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Detections : Page Filters "after each" hook for "Changed banner should hide on Reset"
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Detections : Page Filters Changed banner should hide on Reset

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pmuellr pmuellr added v8.8.0 v8.9.0 and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels May 15, 2023
@pmuellr pmuellr merged commit b542862 into elastic:main May 15, 2023
@kibanamachine kibanamachine mentioned this pull request May 15, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 15, 2023
@pmuellr
[ResponseOps][Task Manager] stop spamming the logs on status changes (e…
a19fd48 
…lastic#157762)

resolves elastic#156112

Change task manager logging on status errors from `warn` to `debug.
Making this change as we recently changed from `debug` to `warn` in
elastic#154045 . But this ended up too
noisy, especially at Kibana startup.

(cherry picked from commit b542862)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 15, 2023
@kibanamachine @pmuellr
[8.8] [ResponseOps][Task Manager] stop spamming the logs on status ch…
314cc18 
…anges (#157762) (#157800)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[ResponseOps][Task Manager] stop spamming the logs on status changes
(#157762)](#157762)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Patrick
Mueller","email":"patrick.mueller@elastic.co"},"sourceCommit":{"committedDate":"2023-05-15T20:21:16Z","message":"[ResponseOps][Task
Manager] stop spamming the logs on status changes (#157762)\n\nresolves
https://github.com/elastic/kibana/issues/156112\r\n\r\nChange task
manager logging on status errors from `warn` to `debug.\r\nMaking this
change as we recently changed from `debug` to `warn`
in\r\nhttps://github.com//pull/154045 . But this ended up
too\r\nnoisy, especially at Kibana
startup.","sha":"b542862904073982a00ecd7418cc77dbe567b2d0","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Task
Manager","Team:ResponseOps","v8.8.0","v8.9.0"],"number":157762,"url":"https://github.com/elastic/kibana/pull/157762","mergeCommit":{"message":"[ResponseOps][Task
Manager] stop spamming the logs on status changes (#157762)\n\nresolves
https://github.com/elastic/kibana/issues/156112\r\n\r\nChange task
manager logging on status errors from `warn` to `debug.\r\nMaking this
change as we recently changed from `debug` to `warn`
in\r\nhttps://github.com//pull/154045 . But this ended up
too\r\nnoisy, especially at Kibana
startup.","sha":"b542862904073982a00ecd7418cc77dbe567b2d0"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157762","number":157762,"mergeCommit":{"message":"[ResponseOps][Task
Manager] stop spamming the logs on status changes (#157762)\n\nresolves
https://github.com/elastic/kibana/issues/156112\r\n\r\nChange task
manager logging on status errors from `warn` to `debug.\r\nMaking this
change as we recently changed from `debug` to `warn`
in\r\nhttps://github.com//pull/154045 . But this ended up
too\r\nnoisy, especially at Kibana
startup.","sha":"b542862904073982a00ecd7418cc77dbe567b2d0"}}]}]
BACKPORT-->

Co-authored-by: Patrick Mueller <patrick.mueller@elastic.co>
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
@pmuellr @jasonrhodes
[ResponseOps][Task Manager] stop spamming the logs on status changes (#…
8a82574 
…157762)

resolves #156112

Change task manager logging on status errors from `warn` to `debug.
Making this change as we recently changed from `debug` to `warn` in
#154045 . But this ended up too
noisy, especially at Kibana startup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

Assignees
No one assigned
Labels
Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ResponseOps] task manager spamming the Kibana log at startup
5 participants
@pmuellr @elasticmachine @kibana-ci @kibanamachine @ymao1