Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds Global Settings #157769

Merged
merged 2 commits into from
May 15, 2023
Merged

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented May 15, 2023

@KOTungseth KOTungseth added Team:Docs release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.8.0 labels May 15, 2023
@KOTungseth KOTungseth requested a review from rshen91 May 15, 2023 16:48
@KOTungseth KOTungseth self-assigned this May 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@github-actions
Copy link

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@rshen91 rshen91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOICE! Thanks for adding the pixel sizes!!

*Advanced Settings* control the behavior of {kib}. For example, you can change the format used to display dates,
specify the default data view, and set the precision for displayed decimal values.
*Advanced Settings* control the behavior of {kib}. You can change the settings that apply to spaces, or to all of {kib}. For example, you can change the format used to display dates,
specify the default data view, and apply your own branding.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooo!!!

@KOTungseth KOTungseth merged commit 037ff39 into elastic:main May 15, 2023
@KOTungseth KOTungseth deleted the docs/custom-branding branch May 15, 2023 17:42
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 15, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 15, 2023
# Backport

This will backport the following commits from `main` to `8.8`:
- [[DOCS] Adds Global Settings
(#157769)](#157769)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kaarina
Tungseth","email":"kaarina.tungseth@elastic.co"},"sourceCommit":{"committedDate":"2023-05-15T17:41:51Z","message":"[DOCS]
Adds Global Settings (#157769)\n\n## Summary\r\n\r\nAdds the 8.8 docs
for Kibana Global Settings,
including\r\nhttps://github.com//pull/151631.\r\n\r\nDocs
preview:\r\nhttps://kibana_157769.docs-preview.app.elstc.co/guide/en/kibana/master/advanced-options.html#kibana-global-settings-reference","sha":"037ff39062e81f0e3a39af8c606007247bd4794c","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","Team:SharedUX","v8.8.0","v8.9.0"],"number":157769,"url":"https://github.com/elastic/kibana/pull/157769","mergeCommit":{"message":"[DOCS]
Adds Global Settings (#157769)\n\n## Summary\r\n\r\nAdds the 8.8 docs
for Kibana Global Settings,
including\r\nhttps://github.com//pull/151631.\r\n\r\nDocs
preview:\r\nhttps://kibana_157769.docs-preview.app.elstc.co/guide/en/kibana/master/advanced-options.html#kibana-global-settings-reference","sha":"037ff39062e81f0e3a39af8c606007247bd4794c"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157769","number":157769,"mergeCommit":{"message":"[DOCS]
Adds Global Settings (#157769)\n\n## Summary\r\n\r\nAdds the 8.8 docs
for Kibana Global Settings,
including\r\nhttps://github.com//pull/151631.\r\n\r\nDocs
preview:\r\nhttps://kibana_157769.docs-preview.app.elstc.co/guide/en/kibana/master/advanced-options.html#kibana-global-settings-reference","sha":"037ff39062e81f0e3a39af8c606007247bd4794c"}}]}]
BACKPORT-->

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants