-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] hide error panel for test run logs for lightweight monitors #157791
Merged
shahzad31
merged 2 commits into
elastic:main
from
dominiqueclarke:fix/synthetics-hide-error-panel
May 16, 2023
Merged
[Synthetics] hide error panel for test run logs for lightweight monitors #157791
shahzad31
merged 2 commits into
elastic:main
from
dominiqueclarke:fix/synthetics-hide-error-panel
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiqueclarke
added
bug
Fixes for quality problems that affect the customer experience
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
release_note:skip
Skip the PR/issue when compiling release notes
v8.8.0
v8.9.0
labels
May 15, 2023
Pinging @elastic/uptime (Team:uptime) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
shahzad31
approved these changes
May 15, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 16, 2023
…ors (elastic#157791) (cherry picked from commit 2dfaf21)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 16, 2023
… monitors (#157791) (#157836) # Backport This will backport the following commits from `main` to `8.8`: - [[Synthetics] hide error panel for test run logs for lightweight monitors (#157791)](#157791) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dominique Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2023-05-16T08:04:38Z","message":"[Synthetics] hide error panel for test run logs for lightweight monitors (#157791)","sha":"2dfaf21c64558c7300d7d6491d40992b5657b7d1","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.8.0","v8.9.0"],"number":157791,"url":"https://github.com/elastic/kibana/pull/157791","mergeCommit":{"message":"[Synthetics] hide error panel for test run logs for lightweight monitors (#157791)","sha":"2dfaf21c64558c7300d7d6491d40992b5657b7d1"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157791","number":157791,"mergeCommit":{"message":"[Synthetics] hide error panel for test run logs for lightweight monitors (#157791)","sha":"2dfaf21c64558c7300d7d6491d40992b5657b7d1"}}]}] BACKPORT--> Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
jasonrhodes
pushed a commit
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v8.8.0
v8.9.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hides error details panel for test run logs for lightweight monitors.
Before:
After:
The bottom empty panel should not appear