Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Add feature flag to sourcemap endpoints #157997

Merged
merged 1 commit into from
May 22, 2023
Merged

[APM] Add feature flag to sourcemap endpoints #157997

merged 1 commit into from
May 22, 2023

Conversation

MiriamAparicio
Copy link
Contributor

@MiriamAparicio MiriamAparicio commented May 17, 2023 •
edited
Loading

Part of #153776

Disallow uploading source maps endpoints to make it clear that it won't work by returning 501 Not Implemented status code

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@MiriamAparicio MiriamAparicio added Team:APM All issues that need APM UI Team support v8.9.0 release_note:feature Makes this part of the condensed release notes labels May 17, 2023
@MiriamAparicio MiriamAparicio marked this pull request as ready for review May 17, 2023 14:58
@MiriamAparicio MiriamAparicio requested a review from a team as a code owner May 17, 2023 14:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

yngrdyn
yngrdyn approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dgieselaar
dgieselaar approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I'd like to see API tests but we still need to figure out how to handle serverless configs.

@MiriamAparicio MiriamAparicio merged commit 97e6c84 into elastic:main May 22, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 22, 2023
@MiriamAparicio MiriamAparicio deleted the 153776-serverless-api-modifications branch May 22, 2023 07:56
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
@MiriamAparicio @delanni
[APM] Add feature flag to sourcemap endpoints (elastic#157997)
a00b63a 
Part of elastic#153776

Disallow uploading source maps endpoints to make it clear that it won't
work by returning 501 Not Implemented status code
@MiriamAparicio MiriamAparicio mentioned this pull request Jun 1, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

@yngrdyn yngrdyn yngrdyn approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:APM All issues that need APM UI Team support v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MiriamAparicio @apmmachine @elasticmachine @kibana-ci @dgieselaar @yngrdyn @kibanamachine