Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless Search] Select language clients in Overview page #158024

Merged
merged 23 commits into from
May 23, 2023
Merged

[Serverless Search] Select language clients in Overview page #158024

merged 23 commits into from
May 23, 2023

Conversation

saarikabhasi
Copy link
Member

@saarikabhasi saarikabhasi commented May 17, 2023 •
edited
Loading

Summary

  • Select language clients in Overview page
  • Updated svg images with 128 px * 128 px
select.language.clients.demo.mov

Updated Screenshot : Select language with reduced image size and flex group

Screenshot 2023-05-18 at 10 50 50 AM

@saarikabhasi saarikabhasi added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.9.0 labels May 17, 2023
@saarikabhasi saarikabhasi marked this pull request as ready for review May 17, 2023 19:40
@saarikabhasi saarikabhasi requested a review from a team May 17, 2023 19:40
@saarikabhasi saarikabhasi force-pushed the serverless/getting-started-language-selector branch from 0fa280e to a75c158 Compare May 17, 2023 19:52
TattdCodeMonkey
TattdCodeMonkey approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good. Left a few nits, the only thing that is probably worth changing IMO is refactoring the panelItems to be a component that takes the language as a prop.

...ck/plugins/serverless_search/public/application/components/overview_panels/select_client.tsx Outdated Show resolved Hide resolved
...ck/plugins/serverless_search/public/application/components/overview_panels/select_client.tsx Outdated Show resolved Hide resolved
...ck/plugins/serverless_search/public/application/components/overview_panels/select_client.tsx Outdated Show resolved Hide resolved
@saarikabhasi saarikabhasi requested a review from a team as a code owner May 23, 2023 14:47
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
serverlessSearch 62 69 +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
serverlessSearch 33.7KB 37.6KB +3.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
serverlessSearch 25.6KB 25.8KB +158.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 403 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 483 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@saarikabhasi saarikabhasi merged commit 3b4c772 into elastic:main May 23, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 23, 2023
@saarikabhasi saarikabhasi deleted the serverless/getting-started-language-selector branch May 23, 2023 18:26
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
@saarikabhasi @kibanamachine @delanni
[Serverless Search] Select language clients in Overview page (elastic…
d208561 
…#158024)

## Summary

* Select language clients in Overview page
* Updated svg images with 128 px * 128 px



https://github.com/elastic/kibana/assets/55930906/b46cfa6b-652e-4914-af88-2fbd892f54eb

**Updated Screenshot : Select language with reduced image size and flex
group**

<img width="1728" alt="Screenshot 2023-05-18 at 10 50 50 AM"
src="https://github.com/elastic/kibana/assets/55930906/42f8865e-20f0-41e4-9ce5-bb683031324f">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveyholler daveyholler daveyholler approved these changes

@sloanelybutsurely sloanelybutsurely sloanelybutsurely approved these changes

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

@julianrosado julianrosado julianrosado approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@saarikabhasi @kibana-ci @daveyholler @sloanelybutsurely @TattdCodeMonkey @julianrosado @kibanamachine