Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] filters - remove public so client usage #158095

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented May 18, 2023

Summary

Relates to #153399

Resolves the following task from the referenced issue

Removes public SO client usage for the fetching monitor filters options, by creating a new GET route for getting the available filters and their count.

Testing

This PR affects filters on the overview and management pages. To test, create a few monitors with various combinations of configurations to filter against, for example monitor type, location, tags, and schedule. Be sure to also create a few project monitors.

Utilize the filters on both pages to test for regression.

@dominiqueclarke dominiqueclarke added enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.9.0 labels May 18, 2023
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner May 18, 2023 17:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 1257 1258 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.2MB 1.2MB -719.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 403 +4
total +6

References to deprecated APIs

id before after diff
synthetics 114 110 -4

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 483 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 8f16d9e into elastic:main May 23, 2023
@shahzad31 shahzad31 deleted the fix/synthetics-filters-remove-public-so-references branch May 23, 2023 20:01
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 23, 2023
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
Co-authored-by: shahzad31 <shahzad31comp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants