[Serverless] Disable UI of Users, Roles, and Role Mappings #158186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaStoeva
added
Team:Kibana Management
5 tasks
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
legrego
reviewed
May 22, 2023
There was a problem hiding this comment.
@ElenaStoeva thanks for putting this PR together for us, much appreciated! I left a couple of comments below for your review.
x-pack/plugins/security/public/management/management_service.test.ts
Outdated
Show resolved
Hide resolved
|
Thanks a lot for the review @legrego! I made the suggested changes and left a couple of follow-up comments. Let me know your thoughts on these. |
legrego
reviewed
May 23, 2023
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
kibanamachine
added
v8.9.0
backport:skip
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
…58186) Partially addresses elastic#157756 ## Summary This PR makes the UI of the following Security apps disable-able for serverless: - Users - Roles - Role Mappings **How to test:** 1. Start Elasticsearch with `yarn es snapshot` and Kibana with yarn `serverless-{mode}` where `{mode}` can be `es`, `security`, or `oblt`. 2. Verify that the Users app is not accessible and its path (`management/security/users`) leads to the Stack Management landing page. 3. Verify that the Roles app is not accessible and its path (`management/security/roles`) leads to the Stack Management landing page. 4. Verify that the Role Mappings app is not accessible and its path (`management/security/role_mappings`) leads to the Stack Management landing page. Test the Security apps in regular (non-serverless) mode: 1. Start Elasticsearch with `yarn es snapshot` and Kibana with `yarn start`. 2. Verify that Users, Roles, and Role Mappings apps work as expected.
ElenaStoeva
added a commit
that referenced
this pull request
Jul 24, 2023
…#162187) This is a follow-up to #160671, where the Management plugins were disabled using `contextRef`. The configs for disabling the UI of the security management plugins were added in #158186. In this PR, they are changed so that they follow the same convention for disabling the Management plugins - setting the default values of the configs to `true` and explicitly setting them to `false` in the `serverless.yml` file. This way, we have a clear view in `serverless.yml` of all plugins/functionalities that have been disabled.
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…elastic#162187) This is a follow-up to elastic#160671, where the Management plugins were disabled using `contextRef`. The configs for disabling the UI of the security management plugins were added in elastic#158186. In this PR, they are changed so that they follow the same convention for disabling the Management plugins - setting the default values of the configs to `true` and explicitly setting them to `false` in the `serverless.yml` file. This way, we have a clear view in `serverless.yml` of all plugins/functionalities that have been disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #157756
Summary
This PR makes the UI of the following Security apps disable-able for serverless:
How to test:
yarn es snapshotand Kibana with yarnserverless-{mode}where{mode}can bees,security, oroblt.management/security/users) leads to the Stack Management landing page.management/security/roles) leads to the Stack Management landing page.management/security/role_mappings) leads to the Stack Management landing page.Test the Security apps in regular (non-serverless) mode:
yarn es snapshotand Kibana withyarn start.