Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oblt: support github command for serverless #158237

Merged
merged 3 commits into from
May 23, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented May 23, 2023

Summary

Enable the GitHub comment /oblt-deploy-serverless so any PRs targeting the main branch can be deployed against the serverless Observability deployment.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v v1v requested a review from kuisathaverat May 23, 2023 08:50
@v1v v1v self-assigned this May 23, 2023
@v1v v1v added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting skip-ci labels May 23, 2023
@v1v v1v marked this pull request as ready for review May 23, 2023 09:56
@v1v v1v requested a review from a team as a code owner May 23, 2023 09:56
@v1v v1v requested review from sorenlouv and a team May 23, 2023 09:57
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@v1v v1v enabled auto-merge (squash) May 23, 2023 13:12
@v1v v1v merged commit d68317d into elastic:main May 23, 2023
v1v added a commit that referenced this pull request May 24, 2023
@@ -50,6 +50,7 @@ jobs:

Just comment with:
- \`/oblt-deploy\` : Deploy a Kibana instance using the Observability test environments.
- \`/oblt-deploy-serverless\` : Deploy a Kibana instance using the Observability `serverless` test environment [only for main].
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caused some errors

https://github.com/elastic/kibana/actions/runs/5067896794/jobs/9099512431?pr=158363#step:4:12

likely the [...] is the reason

- \`/oblt-deploy-serverless\` : Deploy a Kibana instance using the Observability `serverless` test environment - only for main.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or rather, the unescaped backticks `` around serverless?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct! Thanks for the 👀 , I typed faster than needed 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes skip-ci v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants