Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Drop duplicate lint check #158259

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented May 23, 2023

Summary

Noticed a duplicate lint check in a pr I was working on.
Considering what this check does, we prolly really do not want to run it twice, unless this was not a mistake.

@wayneseymour wayneseymour added release_note:skip Skip the PR/issue when compiling release notes buildkite-ci labels May 23, 2023
@wayneseymour wayneseymour self-assigned this May 23, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 403 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 483 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

@wayneseymour wayneseymour marked this pull request as ready for review May 23, 2023 14:45
@wayneseymour wayneseymour requested a review from a team as a code owner May 23, 2023 14:45
@wayneseymour wayneseymour merged commit c8cd3b5 into elastic:main May 23, 2023
@wayneseymour wayneseymour deleted the dedupe-checks branch May 23, 2023 14:45
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 23, 2023
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
## Summary

Noticed a duplicate lint check in a
[pr](https://buildkite.com/elastic/kibana-pull-request/builds/129550#01884877-20a5-4b7d-a395-9bd70bac3f75)
I was working on.
Considering what this check does, we prolly really do not want to run it
twice, unless this was not a mistake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting buildkite-ci release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants