Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] remove invalid arg from scripts/generate_plugin example #159466

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

watson
Copy link
Contributor

@watson watson commented Jun 12, 2023

Since version 8.0.0 of Kibana it's not been possible to supply the plugin name directly on the command line like it's described in the docs. You instead need to use the --name flag. However, this is now optional, so you could just leave out the name entirely and the CLI will ask you for it.

In this PR I've opted to remove the name from the command instead of using the --name flag as there are so many other options you could provide, so highlighting --name specifically isn't really warranted IMO. It also makes the "code-block" easier to read as we can remove the trailing comment.

@github-actions
Copy link

Documentation preview:

@watson watson requested a review from a team June 12, 2023 13:10
@watson watson merged commit 11bcdb7 into elastic:main Jun 14, 2023
@watson watson deleted the fix-docs2 branch June 14, 2023 10:07
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 14, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 14, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 14, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 14, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 14, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.0
8.1
8.2
8.3
8.4
8.5
8.6
8.7
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 14, 2023
watson pushed a commit that referenced this pull request Jun 15, 2023
watson pushed a commit that referenced this pull request Jun 15, 2023
watson pushed a commit that referenced this pull request Jun 15, 2023
watson pushed a commit that referenced this pull request Jun 15, 2023
watson pushed a commit that referenced this pull request Jun 15, 2023
watson pushed a commit that referenced this pull request Jun 15, 2023
watson pushed a commit that referenced this pull request Jun 15, 2023
watson pushed a commit that referenced this pull request Jun 15, 2023
watson pushed a commit that referenced this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants