Enable restriction of internal APIs for serverless #161733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyos
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @pheyos |
pgayvallet
reviewed
Jul 13, 2023
Comment on lines
50
to
+51
| # Enforce restring access to internal APIs see https://github.com/elastic/kibana/issues/151940 | ||
| # server.restrictInternalApis: true | ||
| server.restrictInternalApis: true |
There was a problem hiding this comment.
Hum, Tina or JL would need to confirm, but I think doing that in the "production" config file may break a lot of things ATM.
Why not doing it via CLI args in the FTR suites that are supposed to run against serverless, as we do for every other suite and/or setting when we need to override the defaults for a given FTR suite?
More globally, I don't think a test-only feature or change should ever need to touch the config folder.
There was a problem hiding this comment.
@jloleysens I missed this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables the serverless configuration entry to restrict internal API access and adds the required header to serverless API integration tests so they can still request these APIs.
Follow up on #156935