Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Version connectors domain and apis #162059

Merged
merged 21 commits into from
Jul 19, 2023
Merged

[Cases] Version connectors domain and apis #162059

merged 21 commits into from
Jul 19, 2023

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Jul 17, 2023 •
edited
Loading

Summary

This PR versions the connector domain object and its corresponding APIs

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.10.0 labels Jul 17, 2023
@cnasikas cnasikas self-assigned this Jul 17, 2023
@cnasikas cnasikas mentioned this pull request Jul 17, 2023
Open
30 tasks
@cnasikas cnasikas mentioned this pull request Jul 18, 2023
Merged
2 tasks
@cnasikas cnasikas marked this pull request as ready for review July 18, 2023 13:48
@cnasikas cnasikas requested review from a team as code owners July 18, 2023 13:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas cnasikas removed the request for review from paul-tavares July 18, 2023 13:49
js-jankisalvi
js-jankisalvi reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! Folder structure is much more clear now 😄

x-pack/plugins/cases/common/index.ts
@@ -40,13 +40,14 @@ export {
LENS_ATTACHMENT_TYPE,
} from './constants';

export { ConnectorTypes } from './types/domain';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these are from latest ConnectorTypes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is used by plugins outside Cases. They should always get the latest version.

x-pack/plugins/cases/common/types/domain/connector/v1.ts
* Jira
*/

export const JiraFieldsRt = rt.strict({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like this new structure where all types related to connector are in single file. Easy to read 😄

adcoelho
adcoelho approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@adcoelho adcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a few comments 👍

@cnasikas cnasikas added the ci:skip-cypress-osquery Skips osquery cypress checks label Jul 19, 2023
@cnasikas cnasikas enabled auto-merge (squash) July 19, 2023 10:43
@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 659 654 -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 422.1KB 422.1KB +11.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 148.1KB 148.3KB +139.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas merged commit 4540b38 into elastic:main Jul 19, 2023
@cnasikas cnasikas deleted the version_connectors branch July 19, 2023 12:34
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 19, 2023
Ruhshan pushed a commit to Ruhshan/kibana that referenced this pull request Jul 19, 2023
@cnasikas @kibanamachine @Ruhshan
[Cases] Version connectors domain and apis (elastic#162059)
551e6e9 
## Summary

This PR versions the `connector` domain object and its corresponding
APIs

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cnasikas added a commit that referenced this pull request Jul 26, 2023
@cnasikas @kibanamachine
[Cases] Version cases and comment domain and apis (#161954)
2221ff8 
## Summary

This PR versions the `cases` and `comment` domain objects and their
corresponding APIs. It was not possible to do them separately as I got
errors due to circular dependencies.

## Notable Changes
- The `Comment` type was renamed to `Attachment`
- The `Comments` type was renamed to `Attachments`
- The `*CommentRequestRt` type was renamed to `*AttachmentPayload`
- The `CommentType` type was  renamed to `AttachmentType`
- The `AttributesType*` type was renamed to `*AttachmentAttributes`
- The `*ResponseTypeUserRt` type was renamed to `*AttachmentRt`
- The word `comment` got replaced with the word `attachment` in all
types
- The `RelatedCaseInfo` type was renamed to `RelatedCase`
- The `CasesByAlertId` type was renamed to
`GetRelatedCasesByAlertResponse`

Depends on: #161783,
#162059

### Checklist

Delete any items that do not apply to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
rshen91 pushed a commit to rshen91/kibana that referenced this pull request Jul 26, 2023
@cnasikas @kibanamachine @rshen91
[Cases] Version cases and comment domain and apis (elastic#161954)
5bcc255 
## Summary

This PR versions the `cases` and `comment` domain objects and their
corresponding APIs. It was not possible to do them separately as I got
errors due to circular dependencies.

## Notable Changes
- The `Comment` type was renamed to `Attachment`
- The `Comments` type was renamed to `Attachments`
- The `*CommentRequestRt` type was renamed to `*AttachmentPayload`
- The `CommentType` type was  renamed to `AttachmentType`
- The `AttributesType*` type was renamed to `*AttachmentAttributes`
- The `*ResponseTypeUserRt` type was renamed to `*AttachmentRt`
- The word `comment` got replaced with the word `attachment` in all
types
- The `RelatedCaseInfo` type was renamed to `RelatedCase`
- The `CasesByAlertId` type was renamed to
`GetRelatedCasesByAlertResponse`

Depends on: elastic#161783,
elastic#162059

### Checklist

Delete any items that do not apply to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
@cnasikas @kibanamachine
[Cases] Version connectors domain and apis (elastic#162059)
a8de58f 
## Summary

This PR versions the `connector` domain object and its corresponding
APIs

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
@cnasikas @kibanamachine
[Cases] Version cases and comment domain and apis (elastic#161954)
fc662ca 
## Summary

This PR versions the `cases` and `comment` domain objects and their
corresponding APIs. It was not possible to do them separately as I got
errors due to circular dependencies.

## Notable Changes
- The `Comment` type was renamed to `Attachment`
- The `Comments` type was renamed to `Attachments`
- The `*CommentRequestRt` type was renamed to `*AttachmentPayload`
- The `CommentType` type was  renamed to `AttachmentType`
- The `AttributesType*` type was renamed to `*AttachmentAttributes`
- The `*ResponseTypeUserRt` type was renamed to `*AttachmentRt`
- The word `comment` got replaced with the word `attachment` in all
types
- The `RelatedCaseInfo` type was renamed to `RelatedCase`
- The `CasesByAlertId` type was renamed to
`GetRelatedCasesByAlertResponse`

Depends on: elastic#161783,
elastic#162059

### Checklist

Delete any items that do not apply to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adcoelho adcoelho adcoelho approved these changes

@js-jankisalvi js-jankisalvi js-jankisalvi left review comments

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees

@cnasikas cnasikas

Labels
backport:skip This commit does not require backporting ci:skip-cypress-osquery Skips osquery cypress checks Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cnasikas @elasticmachine @kibana-ci @adcoelho @patrykkopycinski @js-jankisalvi @kibanamachine