Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saved objects #1627

Merged
merged 11 commits into from
Oct 10, 2014
Merged

Fix saved objects #1627

merged 11 commits into from
Oct 10, 2014

Conversation

w33ble
Copy link
Contributor

@w33ble w33ble commented Oct 10, 2014

Fixes #1625
Fixes #1624

This handles several important things

  • In the savedObject list, clicking on the item brings you to edit mode instead of view mode
  • When a savedObject's indexPattern is missing, it takes you to the savedObject editor
    • Uses raw ES queries so the savedObject can be removed
      • Previously, you'd be stuck in a loop asking you to define an index pattern
  • RedirectWhenMissing now appends the missing param to the URL
  • The savedObject editor looks for the missing param in the URL and shows an error message about it
    • Encourages you to delete the savedObject
  • Saved Dashboard objects in BETA1 had an indexPattern when they shouldn't, this will ignore them
    • Will also remove the indexPattern when saving/updating
  • Apps will now fatally error on an unmatched redirectWhenMissing condition instead of just clearing the session

There's also a tiny amount of code style fixes and debugging cleanup

Big thanks to @spenceralger on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants