Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Flaky ML rule execution tests #163095

Merged
merged 2 commits into from
Aug 10, 2023
Merged

[Security Solution] Flaky ML rule execution tests #163095

merged 2 commits into from
Aug 10, 2023

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented Aug 3, 2023 •
edited
Loading

Summary

Original ticket: #145776

Un-skip ML rule execution flaky tests.

Currently these tests are failing due to these ML APIs changes (API versioning) #156949

@e40pud e40pud added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area labels Aug 3, 2023
@e40pud e40pud self-assigned this Aug 3, 2023
@e40pud e40pud marked this pull request as ready for review August 4, 2023 08:40
@e40pud e40pud requested a review from a team as a code owner August 4, 2023 08:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@e40pud
Copy link
Contributor Author

e40pud commented Aug 4, 2023

Passed 497 times against flaky test runner

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

WafaaNasr
WafaaNasr approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@WafaaNasr WafaaNasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@e40pud e40pud merged commit c8b1d98 into elastic:main Aug 10, 2023
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Aug 10, 2023
@e40pud e40pud mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WafaaNasr WafaaNasr WafaaNasr approved these changes

Assignees

@e40pud e40pud

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@e40pud @elasticmachine @kibana-ci @WafaaNasr @kibanamachine