Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Update Workplace Search connectors doclink #163676

Merged
merged 2 commits into from
Aug 11, 2023
Merged

[Enterprise Search] Update Workplace Search connectors doclink #163676

merged 2 commits into from
Aug 11, 2023

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Aug 11, 2023 •
edited by kibanamachine
Loading

Small URL update.

@leemthompo leemthompo added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 labels Aug 11, 2023
@leemthompo leemthompo requested a review from a team August 11, 2023 08:19
@leemthompo leemthompo self-assigned this Aug 11, 2023
@leemthompo leemthompo requested a review from a team as a code owner August 11, 2023 08:19
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

florent-leborgne
florent-leborgne approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leemthompo leemthompo enabled auto-merge (squash) August 11, 2023 09:00
@leemthompo leemthompo merged commit c8e5741 into elastic:main Aug 11, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 144.7KB 144.6KB -11.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 378.2KB 378.2KB -11.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @leemthompo

@kibanamachine kibanamachine mentioned this pull request Aug 11, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 11, 2023
@leemthompo
[Enterprise Search] Update Workplace Search connectors doclink (elast…
f3ce956 
…ic#163676)

Small URL update.

(cherry picked from commit c8e5741)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 11, 2023
@kibanamachine @leemthompo
[8.9] [Enterprise Search] Update Workplace Search connectors doclink (#…
55f90c0 
…163676) (#163686)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Enterprise Search] Update Workplace Search connectors doclink
(#163676)](#163676)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Liam
Thompson","email":"32779855+leemthompo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-11T09:27:26Z","message":"[Enterprise
Search] Update Workplace Search connectors doclink (#163676)\n\nSmall
URL
update.","sha":"c8e5741a0b4722d1adb8e532ab2997b30d664fc1","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.9.0","v8.10.0"],"number":163676,"url":"#163676
Search] Update Workplace Search connectors doclink (#163676)\n\nSmall
URL
update.","sha":"c8e5741a0b4722d1adb8e532ab2997b30d664fc1"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"#163676
Search] Update Workplace Search connectors doclink (#163676)\n\nSmall
URL update.","sha":"c8e5741a0b4722d1adb8e532ab2997b30d664fc1"}}]}]
BACKPORT-->

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 11, 2023
@jloleysens
Merge branch 'main' into send-build-number-in-header
832af82 
* main: (64 commits)
  [ML] Transforms: Fix privileges check. (elastic#163687)
  [Log Explorer] Add test suite for Dataset Selector (elastic#163079)
  [Security Solution][Endpoint] Add API checks to Endpoint Policy create/update for checking `endpointPolicyProtections` is enabled (elastic#163429)
  [Security Solution] Fix flaky test: x-pack/test/detection_engine_api_integration/security_and_spaces/update_prebuilt_rules_package/update_prebuilt_rules_package·ts - update_prebuilt_rules_package should allow user to install prebuilt rules from scratch, then install new rules and upgrade existing rules from the new package (elastic#163241)
  [Security Solution] expandable flyout - replace feature flag with advanced settings toggle (elastic#161614)
  [DOCS] Adds the release notes for the 8.9.1 release. (elastic#163578)
  [FTR] Implement browser network condition utils (elastic#163633)
  [Security Solution] Unskip rules table auto-refresh Cypress tests (elastic#163451)
  [Security Solution] Re-enable fixed rule snoozing Cypress test (elastic#160037)
  [Flaky Test elastic#111821] Mock `moment` to avoid midnight TZ issues (elastic#163157)
  Document interactive setup (elastic#163619)
  [Lens] Align decoration color with text color for layer actions (elastic#163630)
  [Lens] Relax counter field checks for saved visualizations with unsupported operations (elastic#163515)
  [Security Solution][Endpoint] Removes pMap and uses a for loop instead (elastic#163509)
  [Enterprise Search] Update Workplace Search connectors doclink (elastic#163676)
  Update APM (main) (elastic#163623)
  [Serverless] Partially fix lens/maps/visualize breadcrumbs missing title  (elastic#163476)
  [Flaky elastic#118272] Unskip tests (elastic#163319)
  [APM] Make service group saved objects exportable (elastic#163569)
  [Observability AI Assistant] Action menu item (elastic#163463)
  ...
benakansara pushed a commit to benakansara/kibana that referenced this pull request Aug 14, 2023
@leemthompo @benakansara
[Enterprise Search] Update Workplace Search connectors doclink (elast…
ba78586 
…ic#163676)

Small URL update.
@mistic
Copy link
Member

mistic commented Aug 17, 2023

This pr didn't make it into the build candidate for v8.9.1. Updating the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florent-leborgne florent-leborgne florent-leborgne approved these changes

@saarikabhasi saarikabhasi saarikabhasi approved these changes

@sphilipse sphilipse sphilipse approved these changes

Assignees

@leemthompo leemthompo

Labels
release_note:skip Skip the PR/issue when compiling release notes v8.9.2 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@leemthompo @apmmachine @kibana-ci @kibanamachine @mistic @florent-leborgne @saarikabhasi @sphilipse