Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.9] [ML] Transforms: Fix privileges check. (#163687) #163725

Merged
merged 1 commit into from
Aug 11, 2023
Merged

[8.9] [ML] Transforms: Fix privileges check. (#163687) #163725

merged 1 commit into from
Aug 11, 2023

Conversation

walterra
Copy link
Contributor

Backport

This will backport the following commits from main to 8.9:

Questions ?

Please refer to the Backport tool documentation

@walterra
[ML] Transforms: Fix privileges check. (elastic#163687)
3be6115 
Fixes a regression introduced in elastic#154007.

When security is disabled, the check for transform
privileges/capabilities would fail and the transform page would not
render.

- This fixes the endpoint to return data in the correct format should
security be disabled.
- The endpoint's TypeScript has been updated to catch malformed
responses.
- The client side custom `useRequest` is replaced with `useQuery` from
`'@tanstack/react-query'` which also fixes TypeScript support on the
client side.

(cherry picked from commit ecaa8a7)

# Conflicts:
#	x-pack/plugins/transform/public/app/app.tsx
@walterra walterra enabled auto-merge (squash) August 11, 2023 14:27
@walterra walterra mentioned this pull request Aug 11, 2023
Merged
2 tasks
jgowdyelastic
jgowdyelastic approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
transform 357 356 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 403.5KB 403.5KB +18.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
transform 17.6KB 17.7KB +54.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 415 419 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 496 500 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@walterra walterra merged commit 6cfb565 into elastic:8.9 Aug 11, 2023
3 checks passed
@walterra walterra deleted the backport/8.9/pr-163687 branch August 21, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walterra @kibana-ci @jgowdyelastic