Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'Create Rule' button from Rule Group page #164167

Merged
merged 11 commits into from
Aug 23, 2023
Merged

Remove 'Create Rule' button from Rule Group page #164167

merged 11 commits into from
Aug 23, 2023

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Aug 17, 2023 •
edited by kibanamachine
Loading

issue: #163462

Summary

Change of plan. We are going to delete the button.

Disable the 'Create Rule' button on the Rule Group page and add the read icon to the topbar when the user is on read mode.
Delete 'Create Rule' button on the Rule Group page

How to reproduce it

  • Create a role with read access to the security solution feature
  • Login with a user that has the created role
  • Open the rule group page

Checklist

Delete any items that are not applicable to this PR.

@machadoum machadoum self-assigned this Aug 17, 2023
@machadoum machadoum added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.10.0 labels Aug 17, 2023
@machadoum machadoum marked this pull request as ready for review August 17, 2023 14:44
@machadoum machadoum requested a review from a team as a code owner August 17, 2023 14:44
@machadoum machadoum requested a review from jpdjere August 17, 2023 14:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@machadoum machadoum changed the title Add RBAC check for new 'Create Rule' button on Rule Group page Remove 'Create Rule' button from Rule Group page Aug 21, 2023
jpdjere
jpdjere approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@jpdjere jpdjere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@machadoum machadoum enabled auto-merge (squash) August 21, 2023 13:34
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Cypress Tests #4 / Bulk editing index patterns of rules with a data view only Delete index patterns in custom rules with configured data view: rules are skipped Delete index patterns in custom rules with configured data view: rules are skipped
  • [job] [logs] Defend Workflows Endpoint Cypress Tests #5 / Isolate command From manage "before all" hook for "should allow filtering endpoint by Isolated status" "before all" hook for "should allow filtering endpoint by Isolated status"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.7MB 15.7MB -383.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit 9aafd1f into elastic:main Aug 23, 2023
35 checks passed
@kibanamachine kibanamachine mentioned this pull request Aug 23, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2023
@machadoum
Remove 'Create Rule' button from Rule Group page (elastic#164167)
e37b34b 
issue: elastic#163462

## Summary

Change of plan. We are going to delete the button.

~Disable the 'Create Rule' button on the Rule Group page and add the
read icon to the topbar when the user is on read mode.~
Delete 'Create Rule' button on the Rule Group page

### How to reproduce it
* ~Create a role with read access to the security solution feature~
* ~Login with a user that has the created role~
* Open the rule group page

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 9aafd1f)
kibanamachine added a commit that referenced this pull request Aug 23, 2023
@kibanamachine @machadoum
[8.10] Remove 'Create Rule' button from Rule Group page (#164167) (#1…
7b1731d 
…64535)

# Backport

This will backport the following commits from `main` to `8.10`:
- [Remove 'Create Rule' button from Rule Group page
(#164167)](#164167)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"machadoum@gmail.com"},"sourceCommit":{"committedDate":"2023-08-23T08:20:32Z","message":"Remove
'Create Rule' button from Rule Group page (#164167)\n\nissue:
https://github.com/elastic/kibana/issues/163462\r\n\r\n##
Summary\r\n\r\nChange of plan. We are going to delete the
button.\r\n\r\n~Disable the 'Create Rule' button on the Rule Group page
and add the\r\nread icon to the topbar when the user is on read
mode.~\r\nDelete 'Create Rule' button on the Rule Group page\r\n\r\n###
How to reproduce it\r\n* ~Create a role with read access to the security
solution feature~\r\n* ~Login with a user that has the created
role~\r\n* Open the rule group page\r\n\r\n### Checklist\r\n\r\nDelete
any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9aafd1ff834c4609317846ed8643faf47a6fb6de","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.10.0","v8.11.0"],"number":164167,"url":"https://github.com/elastic/kibana/pull/164167","mergeCommit":{"message":"Remove
'Create Rule' button from Rule Group page (#164167)\n\nissue:
https://github.com/elastic/kibana/issues/163462\r\n\r\n##
Summary\r\n\r\nChange of plan. We are going to delete the
button.\r\n\r\n~Disable the 'Create Rule' button on the Rule Group page
and add the\r\nread icon to the topbar when the user is on read
mode.~\r\nDelete 'Create Rule' button on the Rule Group page\r\n\r\n###
How to reproduce it\r\n* ~Create a role with read access to the security
solution feature~\r\n* ~Login with a user that has the created
role~\r\n* Open the rule group page\r\n\r\n### Checklist\r\n\r\nDelete
any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9aafd1ff834c4609317846ed8643faf47a6fb6de"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164167","number":164167,"mergeCommit":{"message":"Remove
'Create Rule' button from Rule Group page (#164167)\n\nissue:
https://github.com/elastic/kibana/issues/163462\r\n\r\n##
Summary\r\n\r\nChange of plan. We are going to delete the
button.\r\n\r\n~Disable the 'Create Rule' button on the Rule Group page
and add the\r\nread icon to the topbar when the user is on read
mode.~\r\nDelete 'Create Rule' button on the Rule Group page\r\n\r\n###
How to reproduce it\r\n* ~Create a role with read access to the security
solution feature~\r\n* ~Login with a user that has the created
role~\r\n* Open the rule group page\r\n\r\n### Checklist\r\n\r\nDelete
any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9aafd1ff834c4609317846ed8643faf47a6fb6de"}}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <machadoum@gmail.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 23, 2023
@jloleysens
Merge branch 'main' into zdt-test-harness
fab26f8 
* main: (150 commits)
  Fixes unnecessary autocompletes on HTTP methods (elastic#163233)
  [Defend Workflows] Convert filterQuery to kql  (elastic#161806)
  [Fleet] copy `inactivity_timeout` when duplicating agent policy (elastic#164544)
  Fix 7.17 forward compatibility with 8.2+ (elastic#164274)
  [ML] Fixes dark mode in flyouts and modals (elastic#164399)
  [Defend Workflows]Changes to policy settings are not persistent until a refresh (elastic#164403)
  [Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (elastic#164329)
  Prepare the Security domain HTTP APIs for Serverless (elastic#162087)
  skip failing test suite (elastic#160986)
  [Security Solution] Fix flaky Event Filters test (elastic#164473)
  [EDR workflows] Osquery serverless tests (elastic#163795)
  [Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (elastic#164469)
  [Chrome UI] Fix background color in serverless (elastic#164419)
  [DOCS] Saved objects - resolve import errors API (elastic#162825)
  Remove 'Create Rule' button from Rule Group page (elastic#164167)
  [Security Solution] expandable flyout - fix infinite loop in correlations (elastic#163450)
  [Remote Clusters] Update copy about port help text (elastic#164442)
  [api-docs] 2023-08-23 Daily api_docs build (elastic#164524)
  [data views] Disable scripted fields in serverless environment (elastic#163228)
  [Reporting] Fix - show diagnostic only when image reporting is enabled (elastic#164336)
  ...
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdjere jpdjere jpdjere approved these changes

Assignees

@machadoum machadoum

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@machadoum @elasticmachine @kibana-ci @kibanamachine @jpdjere