[Fleet][Kafka] When compression is enabled, "None" shouldn't be an option for codec #164416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szwarckonrad
added
backport
release_note:skip
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/fleet (Team:Fleet) |
juliaElastic
approved these changes
Aug 22, 2023
kibanamachine
added
v8.11.0
backport:skip
szwarckonrad
added
v8.10.0
and removed
backport
v8.11.0
backport:skip
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
szwarckonrad
added a commit
to szwarckonrad/kibana
that referenced
this pull request
Aug 22, 2023
…tion for codec (elastic#164416) Closes elastic/ingest-dev#2327 `None` option removed from UI, tests aligned. https://github.com/elastic/kibana/assets/29123534/b8b7ac7a-e3e9-4800-94b9-f80e1f42f044 (cherry picked from commit c2a552e)
szwarckonrad
added a commit
that referenced
this pull request
Aug 23, 2023
…e an option for codec (#164416) (#164467) # Backport This will backport the following commits from `main` to `8.10`: - [[Fleet][Kafka] When compression is enabled, "None" shouldn't be an option for codec (#164416)](#164416) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Konrad Szwarc","email":"konrad.szwarc@elastic.co"},"sourceCommit":{"committedDate":"2023-08-22T14:33:39Z","message":"[Fleet][Kafka] When compression is enabled, \"None\" shouldn't be an option for codec (#164416)\n\nCloses https://github.com/elastic/ingest-dev/issues/2327\r\n\r\n`None` option removed from UI, tests aligned. \r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/b8b7ac7a-e3e9-4800-94b9-f80e1f42f044","sha":"c2a552ef66ac8e0c2a0372091ba85b3bf1fa7a3a","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.10.0","v8.11.0"],"number":164416,"url":"https://github.com/elastic/kibana/pull/164416","mergeCommit":{"message":"[Fleet][Kafka] When compression is enabled, \"None\" shouldn't be an option for codec (#164416)\n\nCloses https://github.com/elastic/ingest-dev/issues/2327\r\n\r\n`None` option removed from UI, tests aligned. \r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/b8b7ac7a-e3e9-4800-94b9-f80e1f42f044","sha":"c2a552ef66ac8e0c2a0372091ba85b3bf1fa7a3a"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164416","number":164416,"mergeCommit":{"message":"[Fleet][Kafka] When compression is enabled, \"None\" shouldn't be an option for codec (#164416)\n\nCloses https://github.com/elastic/ingest-dev/issues/2327\r\n\r\n`None` option removed from UI, tests aligned. \r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/b8b7ac7a-e3e9-4800-94b9-f80e1f42f044","sha":"c2a552ef66ac8e0c2a0372091ba85b3bf1fa7a3a"}}]}] BACKPORT-->
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/ingest-dev/issues/2327
Noneoption removed from UI, tests aligned.Screen.Recording.2023-08-22.at.12.35.05.mov