Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs Explorer] Update serverless tests stability #167482

Merged
merged 18 commits into from
Oct 5, 2023
Merged

[Logs Explorer] Update serverless tests stability #167482

merged 18 commits into from
Oct 5, 2023

Conversation

tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Sep 28, 2023 •
edited
Loading

📓 Summary

Update login logic, sorting and search algorithm to stabilize the flaky tests for Log Explorer.

Closes #165915
Closes #165916
Closes #165975
Closes #166016
Closes #166672
Closes #166675
Closes #166817
Closes #167058
Closes #167189
Closes #167499
Closes #167515
Closes #167562
Closes #167567
Closes #167621
Closes #167664
Closes #167773

@tonyghiani tonyghiani added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes labels Sep 28, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tonyghiani tonyghiani mentioned this pull request Sep 28, 2023
Merged
@tonyghiani tonyghiani marked this pull request as ready for review October 3, 2023 07:55
@tonyghiani tonyghiani requested a review from a team as a code owner October 3, 2023 07:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@Kerry350 Kerry350 self-requested a review October 4, 2023 09:05
Kerry350
Kerry350 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Thanks for the increase in stability and spotting the extra issues.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #67 / serverless observability UI Observability ML Anomaly detection jobs list "after all" hook in "Anomaly detection jobs list"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
logExplorer 194.7KB 195.0KB +247.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tonyghiani tonyghiani merged commit 2207928 into elastic:main Oct 5, 2023
20 checks passed
@tonyghiani tonyghiani deleted the log-explorer-testing branch October 5, 2023 10:52
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 5, 2023
This was referenced Oct 5, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
@tonyghiani @kibanamachine @dej611
[Log Explorer] Update serverless tests stability (elastic#167482)
fbf1d04 
## 📓 Summary

Update login logic, sorting and search algorithm to stabilize the flaky
tests for Log Explorer.

Closes elastic#165915
Closes elastic#165916 
Closes elastic#165975  
Closes elastic#166016 
Closes elastic#166672 
Closes elastic#166675 
Closes elastic#166817 
Closes elastic#167058
Closes elastic#167189 
Closes elastic#167499 
Closes elastic#167515  
Closes elastic#167562 
Closes elastic#167567 
Closes elastic#167621 
Closes elastic#167664 
Closes elastic#167773

---------

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@achyutjhunjhunwala achyutjhunjhunwala changed the title [Log Explorer] Update serverless tests stability [Logs Explorer] Update serverless tests stability Jan 3, 2024
@gbamparop gbamparop added the Team:obs-ux-logs Observability Logs User Experience Team label Mar 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerry350 Kerry350 Kerry350 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team:obs-ux-logs Observability Logs User Experience Team v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/observability_log_explorer/dataset_selector·ts - Observability Log Explorer Dataset Selector with installed integrations and uncategorized data streams when open on the first navigation level should filter the integrations list by the typed integration name Failing test: Serverless Observability Functional Tests.x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/dataset_selection_state·ts - serverless observability UI Observability Log Explorer DatasetSelection initialization and update when the "index" query param does not exist should initialize the "All log datasets" selection Failing test: Serverless Observability Functional Tests.x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/dataset_selector·ts - serverless observability UI Observability Log Explorer Dataset Selector with installed integrations and uncategorized data streams when open/close the selector should restore the latest search results Failing test: Serverless Observability Functional Tests.x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/columns_selection·ts - serverless observability UI Observability Log Explorer Columns selection initialization and update "after all" hook in "Columns selection initialization and update" Failing test: Serverless Observability Functional Tests.x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/columns_selection·ts - serverless observability UI Observability Log Explorer Columns selection initialization and update "before all" hook in "Columns selection initialization and update"
Failing test: Serverless Observability Functional Tests.x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/filter_controls·ts - serverless observability UI Observability Log Explorer Filter controls customization renders a filter controls section as part of the unified search bar Failing test: Serverless Observability Functional Tests.x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/dataset_selector·ts - serverless observability UI Observability Log Explorer Dataset Selector without installed integrations or uncategorized data streams when navigating into Uncategorized data streams should display an empty prompt for no data streams Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/observability_log_explorer/dataset_selector·ts - Observability Log Explorer Dataset Selector with installed integrations and uncategorized data streams when open on the integrations tab should display a list of installed integrations Failing test: Serverless Observability Functional Tests.x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/header_menu·ts - serverless observability UI Observability Log Explorer Header menu "before all" hook for "should inject the app header menu on the top navbar" [Log Explorer] Fix flaky tests and serverless testing auth issues
7 participants
@tonyghiani @apmmachine @elasticmachine @kibana-ci @Kerry350 @gbamparop @kibanamachine