Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Unskip misc rule management Serverless Cypress tests #168305

Merged

Conversation

maximpn
Copy link
Contributor

@maximpn maximpn commented Oct 7, 2023

Addresses: #161540

Summary

This PR unskips miscelanious (not falling in one category but unskipping each one separately is overkill) rule management Serverless Cypress tests

  • maintenance_window_callout.cy.ts
  • related_integrations.cy.ts
  • rule_delete.cy.ts
  • rule_snoozing.cy.ts

Flaky test runner

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3405 150 runs 🟢

@maximpn maximpn added test release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team v8.11.0 labels Oct 7, 2023
@maximpn maximpn self-assigned this Oct 7, 2023
@maximpn maximpn force-pushed the unskip-misc-rule-management-cypress-tests branch from 298d5dc to 744ae18 Compare October 7, 2023 11:18
@maximpn maximpn requested a review from banderror October 7, 2023 11:20
@maximpn maximpn marked this pull request as ready for review October 7, 2023 11:22
@maximpn maximpn requested a review from a team as a code owner October 7, 2023 11:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maximpn

Copy link
Contributor

@jpdjere jpdjere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good from test runs 👍

Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@banderror banderror merged commit b7116b1 into elastic:main Oct 9, 2023
42 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2023
…sts (elastic#168305)

**Addresses:** elastic#161540

## Summary

This PR unskips miscelanious (not falling in one category but unskipping
each one separately is overkill) rule management Serverless Cypress
tests

- `maintenance_window_callout.cy.ts`
- `related_integrations.cy.ts`
- `rule_delete.cy.ts`
- `rule_snoozing.cy.ts`

## Flaky test runner

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3405
150 runs 🟢

(cherry picked from commit b7116b1)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 9, 2023
…ress tests (#168305) (#168408)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security Solution] Unskip misc rule management Serverless Cypress
tests (#168305)](#168305)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maxim
Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2023-10-09T20:33:22Z","message":"[Security
Solution] Unskip misc rule management Serverless Cypress tests
(#168305)\n\n**Addresses:**
https://github.com/elastic/kibana/issues/161540\r\n\r\n##
Summary\r\n\r\nThis PR unskips miscelanious (not falling in one category
but unskipping\r\neach one separately is overkill) rule management
Serverless Cypress\r\ntests\r\n\r\n-
`maintenance_window_callout.cy.ts`\r\n-
`related_integrations.cy.ts`\r\n- `rule_delete.cy.ts`\r\n-
`rule_snoozing.cy.ts`\r\n \r\n## Flaky test
runner\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3405\r\n150
runs
🟢","sha":"b7116b1efb96f0cedd8afb6529b8186a9ccdaff2","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","v8.11.0","v8.12.0"],"number":168305,"url":"https://github.com/elastic/kibana/pull/168305","mergeCommit":{"message":"[Security
Solution] Unskip misc rule management Serverless Cypress tests
(#168305)\n\n**Addresses:**
https://github.com/elastic/kibana/issues/161540\r\n\r\n##
Summary\r\n\r\nThis PR unskips miscelanious (not falling in one category
but unskipping\r\neach one separately is overkill) rule management
Serverless Cypress\r\ntests\r\n\r\n-
`maintenance_window_callout.cy.ts`\r\n-
`related_integrations.cy.ts`\r\n- `rule_delete.cy.ts`\r\n-
`rule_snoozing.cy.ts`\r\n \r\n## Flaky test
runner\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3405\r\n150
runs
🟢","sha":"b7116b1efb96f0cedd8afb6529b8186a9ccdaff2"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168305","number":168305,"mergeCommit":{"message":"[Security
Solution] Unskip misc rule management Serverless Cypress tests
(#168305)\n\n**Addresses:**
https://github.com/elastic/kibana/issues/161540\r\n\r\n##
Summary\r\n\r\nThis PR unskips miscelanious (not falling in one category
but unskipping\r\neach one separately is overkill) rule management
Serverless Cypress\r\ntests\r\n\r\n-
`maintenance_window_callout.cy.ts`\r\n-
`related_integrations.cy.ts`\r\n- `rule_delete.cy.ts`\r\n-
`rule_snoozing.cy.ts`\r\n \r\n## Flaky test
runner\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3405\r\n150
runs 🟢","sha":"b7116b1efb96f0cedd8afb6529b8186a9ccdaff2"}}]}]
BACKPORT-->

Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
@maximpn maximpn deleted the unskip-misc-rule-management-cypress-tests branch October 10, 2023 14:03
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
…sts (elastic#168305)

**Addresses:** elastic#161540

## Summary

This PR unskips miscelanious (not falling in one category but unskipping
each one separately is overkill) rule management Serverless Cypress
tests

- `maintenance_window_callout.cy.ts`
- `related_integrations.cy.ts`
- `rule_delete.cy.ts`
- `rule_snoozing.cy.ts`
 
## Flaky test runner


https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3405
150 runs 🟢
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants