[apm][uptime][monitoring] Remove color="ghost" buttons
#169312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
v8.12.0
release_note:skip
11 tasks
- EuiBottomBar now sets a dark color mode on all children, so these colors are no longer necessary to specify
- EuiBottomBar now sets a dark color mode on all children, so these colors are no longer necessary to specify
cee-chen
force-pushed
the
eui-ghost/observability
branch
from
d676bdf
to
9b79429
Compare
cee-chen
changed the title
color="ghost" buttonscolor="ghost" buttons
|
Pinging @elastic/eui-team (EUI) |
cee-chen
added
Team:APM
|
Pinging @elastic/apm-ui (Team:APM) |
|
Pinging @elastic/uptime (Team:uptime) |
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
shahzad31
reviewed
Oct 25, 2023
x-pack/plugins/uptime/public/legacy_uptime/components/settings/settings_actions.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
approved these changes
Oct 25, 2023
weltenwort
approved these changes
Oct 27, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
Thank you all!! 🎉 |
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Oct 30, 2023
) ## Summary 👋 Hey y'all - EUI will shortly be deprecating the `ghost` color in all button components (see https://eui.elastic.co/v89.0.0/#/navigation/button#ghost-vs-dark-mode). In this PR, components using `color="ghost"` within an `EuiBottomBar` already automatically inherit dark mode coloring and should be changed to `color="text"` instead. For the legacy uptime change that adds a theme wrapper, I'm unsure what context it's being used in (does not appear to be a bottom bar) and would appreciate help QAing it. I'm opening this PR ahead of time for your team so you can test this migration and ensure no UI regressions have occurred as a result. ### Checklist - [ ] Tested in light and dark mode --------- Co-authored-by: shahzad31 <shahzad31comp@gmail.com>
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Oct 30, 2023
) ## Summary 👋 Hey y'all - EUI will shortly be deprecating the `ghost` color in all button components (see https://eui.elastic.co/v89.0.0/#/navigation/button#ghost-vs-dark-mode). In this PR, components using `color="ghost"` within an `EuiBottomBar` already automatically inherit dark mode coloring and should be changed to `color="text"` instead. For the legacy uptime change that adds a theme wrapper, I'm unsure what context it's being used in (does not appear to be a bottom bar) and would appreciate help QAing it. I'm opening this PR ahead of time for your team so you can test this migration and ensure no UI regressions have occurred as a result. ### Checklist - [ ] Tested in light and dark mode --------- Co-authored-by: shahzad31 <shahzad31comp@gmail.com>
awahab07
pushed a commit
to awahab07/kibana
that referenced
this pull request
Oct 31, 2023
) ## Summary 👋 Hey y'all - EUI will shortly be deprecating the `ghost` color in all button components (see https://eui.elastic.co/v89.0.0/#/navigation/button#ghost-vs-dark-mode). In this PR, components using `color="ghost"` within an `EuiBottomBar` already automatically inherit dark mode coloring and should be changed to `color="text"` instead. For the legacy uptime change that adds a theme wrapper, I'm unsure what context it's being used in (does not appear to be a bottom bar) and would appreciate help QAing it. I'm opening this PR ahead of time for your team so you can test this migration and ensure no UI regressions have occurred as a result. ### Checklist - [ ] Tested in light and dark mode --------- Co-authored-by: shahzad31 <shahzad31comp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
👋 Hey y'all - EUI will shortly be deprecating the
ghostcolor in all button components (see https://eui.elastic.co/v89.0.0/#/navigation/button#ghost-vs-dark-mode).In this PR, components using
color="ghost"within anEuiBottomBaralready automatically inherit dark mode coloring and should be changed tocolor="text"instead.For the legacy uptime change that adds a theme wrapper, I'm unsure what context it's being used in (does not appear to be a bottom bar) and would appreciate help QAing it.
I'm opening this PR ahead of time for your team so you can test this migration and ensure no UI regressions have occurred as a result.
Checklist