Allow UserProfileSettingsClient to be created on Security Plugin Setup #170172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n setup and set with UserSettingServiceStart on Start to adhere to the setup/start best practices
kc13greiner
added
chore
release_note:skip
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-security (Team:Security) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 2, 2023
elastic#170172) ## Summary Closes elastic#155949 The Security Plugin provides a UserProfileSettings client to the core UserSettingsService on Setup. With the first implementation of Dark Mode, the client was not set until the security UserSettingService was started, which violates the setup/start contract best practices. Now the client is provided during security plugin setup and the security UserSettingService will be set on start. ## Testing Dark Mode should still work as it did before: - Login as elastic - Navigate to User Profile by clicking the Avatar menu > Edit Profile - Choose Dark Mode, Save, and Refresh - Bonus test: double check Adv. Settings Dark Mode vs User Profiles Dark Mode (cherry picked from commit 195ef3d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 2, 2023
…in Setup (#170172) (#170429) # Backport This will backport the following commits from `main` to `8.11`: - [Allow UserProfileSettingsClient to be created on Security Plugin Setup (#170172)](#170172) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kurt","email":"kc13greiner@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-11-02T14:51:43Z","message":"Allow UserProfileSettingsClient to be created on Security Plugin Setup (#170172)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/155949\r\n\r\nThe Security Plugin provides a UserProfileSettings client to the core\r\nUserSettingsService on Setup.\r\n\r\nWith the first implementation of Dark Mode, the client was not set until\r\nthe security UserSettingService was started, which violates the\r\nsetup/start contract best practices.\r\n\r\nNow the client is provided during security plugin setup and the security\r\nUserSettingService will be set on start.\r\n\r\n## Testing\r\n\r\nDark Mode should still work as it did before:\r\n\r\n- Login as elastic\r\n- Navigate to User Profile by clicking the Avatar menu > Edit Profile\r\n- Choose Dark Mode, Save, and Refresh\r\n\r\n- Bonus test: double check Adv. Settings Dark Mode vs User Profiles Dark\r\nMode","sha":"195ef3dc2bd08fad54a0ea8278abffb4f39d39bc","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Security","release_note:skip","Feature:Security/User Profile","v8.12.0","v8.11.1"],"number":170172,"url":"https://github.com/elastic/kibana/pull/170172","mergeCommit":{"message":"Allow UserProfileSettingsClient to be created on Security Plugin Setup (#170172)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/155949\r\n\r\nThe Security Plugin provides a UserProfileSettings client to the core\r\nUserSettingsService on Setup.\r\n\r\nWith the first implementation of Dark Mode, the client was not set until\r\nthe security UserSettingService was started, which violates the\r\nsetup/start contract best practices.\r\n\r\nNow the client is provided during security plugin setup and the security\r\nUserSettingService will be set on start.\r\n\r\n## Testing\r\n\r\nDark Mode should still work as it did before:\r\n\r\n- Login as elastic\r\n- Navigate to User Profile by clicking the Avatar menu > Edit Profile\r\n- Choose Dark Mode, Save, and Refresh\r\n\r\n- Bonus test: double check Adv. Settings Dark Mode vs User Profiles Dark\r\nMode","sha":"195ef3dc2bd08fad54a0ea8278abffb4f39d39bc"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170172","number":170172,"mergeCommit":{"message":"Allow UserProfileSettingsClient to be created on Security Plugin Setup (#170172)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/155949\r\n\r\nThe Security Plugin provides a UserProfileSettings client to the core\r\nUserSettingsService on Setup.\r\n\r\nWith the first implementation of Dark Mode, the client was not set until\r\nthe security UserSettingService was started, which violates the\r\nsetup/start contract best practices.\r\n\r\nNow the client is provided during security plugin setup and the security\r\nUserSettingService will be set on start.\r\n\r\n## Testing\r\n\r\nDark Mode should still work as it did before:\r\n\r\n- Login as elastic\r\n- Navigate to User Profile by clicking the Avatar menu > Edit Profile\r\n- Choose Dark Mode, Save, and Refresh\r\n\r\n- Bonus test: double check Adv. Settings Dark Mode vs User Profiles Dark\r\nMode","sha":"195ef3dc2bd08fad54a0ea8278abffb4f39d39bc"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kurt <kc13greiner@users.noreply.github.com>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Nov 6, 2023
elastic#170172) ## Summary Closes elastic#155949 The Security Plugin provides a UserProfileSettings client to the core UserSettingsService on Setup. With the first implementation of Dark Mode, the client was not set until the security UserSettingService was started, which violates the setup/start contract best practices. Now the client is provided during security plugin setup and the security UserSettingService will be set on start. ## Testing Dark Mode should still work as it did before: - Login as elastic - Navigate to User Profile by clicking the Avatar menu > Edit Profile - Choose Dark Mode, Save, and Refresh - Bonus test: double check Adv. Settings Dark Mode vs User Profiles Dark Mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #155949
The Security Plugin provides a UserProfileSettings client to the core UserSettingsService on Setup.
With the first implementation of Dark Mode, the client was not set until the security UserSettingService was started, which violates the setup/start contract best practices.
Now the client is provided during security plugin setup and the security UserSettingService will be set on start.
Testing
Dark Mode should still work as it did before:
Login as elastic
Navigate to User Profile by clicking the Avatar menu > Edit Profile
Choose Dark Mode, Save, and Refresh
Bonus test: double check Adv. Settings Dark Mode vs User Profiles Dark Mode