Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix type error coming from race condition on plugin type changes #171275

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix type error coming from race condition on plugin type changes #171275

merged 1 commit into from
Nov 15, 2023

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Nov 15, 2023

Summary

Fixes type error coming from merge-race:

#170852 - adds a new plugin
#170856 - changes how plugins should look

@delanni delanni requested a review from a team as a code owner November 15, 2023 10:28
@delanni delanni added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.12.0 labels Nov 15, 2023
@delanni
Copy link
Contributor Author

delanni commented Nov 15, 2023

I'll be admin-merging this once the type checks are passing

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 15, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / Agents CRUD test getAgentsByKuery should return upgradeable on first page
  • [job] [logs] Investigations - Security Solution Cypress Tests #2 / Pagination "before each" hook for "should be able to go to next / previous page" "before each" hook for "should be able to go to next / previous page"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni delanni merged commit dcc478e into elastic:main Nov 15, 2023
16 of 33 checks passed
@delanni delanni deleted the fix-type-errors branch November 15, 2023 11:10
@logeekal logeekal mentioned this pull request Nov 16, 2023
Closed
jillguyonnet pushed a commit to jillguyonnet/kibana that referenced this pull request Nov 16, 2023
@delanni @jillguyonnet
fix type error coming from race condition on plugin type changes (ela…
6a0705f 
…stic#171275)

## Summary
Fixes type error coming from merge-race:

elastic#170852 - adds a new plugin
elastic#170856 - changes how plugins
should look
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomheymann thomheymann thomheymann approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delanni @kibana-ci @thomheymann