[Obs ai assistant][ESQL] Visualizes a query #173076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
commented
Dec 13, 2023
| @@ -32,7 +32,6 @@ const containerClassName = css` | |||
| `; | |||
|
|
|||
| const conversationListContainerName = css` | |||
| min-width: 250px; | |||
There was a problem hiding this comment.
Trying to make it more responsive, otherwise the poor push flyout looks awful
stratoula
commented
Dec 13, 2023
| export const visualizeESQLFunction = { | ||
| name: 'visualize_query', | ||
| description: | ||
| 'Use this function to visualize charts for ES|QL queries. DO NOT run the lens function after.', |
There was a problem hiding this comment.
ℹ️ I had to instruct it to not run the lens function after, not sure if this is the best way to do it but it worked
stratoula
changed the title
stratoula
commented
Dec 14, 2023
| keptLayerIds: string[]; | ||
| } | ||
|
|
||
| export const getLensAttributes = ({ |
There was a problem hiding this comment.
@stratoula reuse this is Lens
|
Half of this code has been merged (at the Visualizations side) and I decided to take a slightly different route so I am closing it in favor of this which is cleaner #174677 and in sync with the latest main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a PoC, do not expect to be awesome :)
This PR
With clicking the apply button, the new chart configuration is saved to the conversation
User can save the ES|QL chart on a dashboard. From there they can continue editing the chart (we also display the same inline editing flyout giving a seamless experience)
Discussion points: