Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obs UX] Unskip transaction duration alerts test #174069

Merged
merged 4 commits into from
Jan 3, 2024
Merged

[Obs UX] Unskip transaction duration alerts test #174069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
316f473
unskip transaction duration alerts test
MiriamAparicio Dec 30, 2023
6a28e4b
Merge branch 'main' into 173267-unskip-transaction-duration-alerts-test
MiriamAparicio Jan 1, 2024
8f7c82d
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Jan 1, 2024
08afa2e
Merge branch 'main' into 173267-unskip-transaction-duration-alerts-test
kibanamachine Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NOTICE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Kibana source code with Kibana X-Pack source code
Copyright 2012-2023 Elasticsearch B.V.
Copyright 2012-2024 Elasticsearch B.V.

---
Pretty handling of logarithmic axes.
Expand Down
10 changes: 4 additions & 6 deletions x-pack/test/apm_api_integration/tests/alerts/transaction_duration.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
groupBy: ['service.name', 'service.environment', 'transaction.type', 'transaction.name'],
};

// FLAKY: https://github.com/elastic/kibana/issues/173267
registry.when.skip('transaction duration alert', { config: 'basic', archives: [] }, () => {
registry.when('transaction duration alert', { config: 'basic', archives: [] }, () => {
before(async () => {
const opbeansJava = apm
.service({ name: 'opbeans-java', environment: 'production', agentName: 'java' })
Expand Down Expand Up @@ -192,7 +191,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
let ruleId: string;
let alerts: ApmAlertFields[];

before(async () => {
beforeEach(async () => {
const createdRule = await createApmRule({
supertest,
ruleTypeId: ApmRuleType.TransactionDuration,
Expand All @@ -213,7 +212,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
alerts = await waitForAlertsForRule({ es, ruleId });
});

after(async () => {
afterEach(async () => {
await cleanupRuleAndAlertState({ es, supertest, logger });
});

Expand All @@ -235,8 +234,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
expect(alerts[0]).property('transaction.name', 'tx-node');
});

// FLAKY: https://github.com/elastic/kibana/issues/173127
it.skip('shows alert count=1 for opbeans-node on service inventory', async () => {
it('shows alert count=1 for opbeans-node on service inventory', async () => {
const serviceInventoryAlertCounts = await fetchServiceInventoryAlertCounts(apmApiClient);
expect(serviceInventoryAlertCounts).to.eql({
'opbeans-node': 1,
Expand Down
Loading