Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Controls] Fix text alignment of options list control selections #175073

Merged
merged 7 commits into from
Jan 30, 2024
Merged

[Controls] Fix text alignment of options list control selections #175073

merged 7 commits into from
Jan 30, 2024

Conversation

Heenawter
Copy link
Contributor

@Heenawter Heenawter commented Jan 17, 2024 •
edited
Loading

Closes #174971

Summary

This PR fixes the alignment issue for the options list control that happened due to the most recent EUI update.

Before After
Jan-17-2024 16-03-07 Jan-17-2024 16-04-00

Checklist

For maintainers

@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Project:Controls labels Jan 17, 2024
@Heenawter Heenawter self-assigned this Jan 17, 2024
@Heenawter
Copy link
Contributor Author

/ci

@Heenawter Heenawter marked this pull request as ready for review January 17, 2024 23:05
@Heenawter Heenawter requested a review from a team as a code owner January 17, 2024 23:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter added the release_note:skip Skip the PR/issue when compiling release notes label Jan 17, 2024
ryankeairns
ryankeairns reviewed Jan 26, 2024
View reviewed changes
src/plugins/controls/public/options_list/components/options_list.scss Outdated
flex-grow: 1;
justify-content: space-between;
width: 0;
.euiFilterButton__text {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a custom class as opposed to overriding .euiFilterButton__text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call 👍 That should hopefully prevent these types of bugs in the future. Done in f1ee5ad

@ryankeairns ryankeairns mentioned this pull request Jan 26, 2024
Closed
@Heenawter Heenawter requested a review from a team as a code owner January 26, 2024 15:52
nreese
nreese approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review only

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 199.4KB 199.3KB -15.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Heenawter

@Heenawter Heenawter merged commit 0a2ccf5 into elastic:main Jan 30, 2024
18 checks passed
@Heenawter Heenawter deleted the fix-control-styling_2024-01-17 branch January 30, 2024 15:28
@Heenawter Heenawter added backport:skip This commit does not require backporting and removed v8.13.0 labels Jan 30, 2024
nreese pushed a commit to nreese/kibana that referenced this pull request Jan 31, 2024
@Heenawter @nreese
[Controls] Fix text alignment of options list control selections (ela…
2f2fa14 
…stic#175073)

Closes elastic#174971

## Summary

This PR fixes the alignment issue for the options list control that
happened due to the most recent EUI update.

| Before | After |
|--------|--------|
| ![Jan-17-2024
16-03-07](https://github.com/elastic/kibana/assets/8698078/d40993fc-ed16-4ca6-86fa-aa156e4ef4d8)
| ![Jan-17-2024
16-04-00](https://github.com/elastic/kibana/assets/8698078/1746cecb-8c93-46a9-b381-1ef07b1d9999)
|

### Checklist

- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Feb 5, 2024
@Heenawter @WafaaNasr
[Controls] Fix text alignment of options list control selections (ela…
6b155cb 
…stic#175073)

Closes elastic#174971

## Summary

This PR fixes the alignment issue for the options list control that
happened due to the most recent EUI update.

| Before | After |
|--------|--------|
| ![Jan-17-2024
16-03-07](https://github.com/elastic/kibana/assets/8698078/d40993fc-ed16-4ca6-86fa-aa156e4ef4d8)
| ![Jan-17-2024
16-04-00](https://github.com/elastic/kibana/assets/8698078/1746cecb-8c93-46a9-b381-1ef07b1d9999)
|

### Checklist

- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Feb 6, 2024
@Heenawter @WafaaNasr
[Controls] Fix text alignment of options list control selections (ela…
73057de 
…stic#175073)

Closes elastic#174971

## Summary

This PR fixes the alignment issue for the options list control that
happened due to the most recent EUI update.

| Before | After |
|--------|--------|
| ![Jan-17-2024
16-03-07](https://github.com/elastic/kibana/assets/8698078/d40993fc-ed16-4ca6-86fa-aa156e4ef4d8)
| ![Jan-17-2024
16-04-00](https://github.com/elastic/kibana/assets/8698078/1746cecb-8c93-46a9-b381-1ef07b1d9999)
|

### Checklist

- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@Heenawter @CoenWarmer
[Controls] Fix text alignment of options list control selections (ela…
60cf48a 
…stic#175073)

Closes elastic#174971

## Summary

This PR fixes the alignment issue for the options list control that
happened due to the most recent EUI update.

| Before | After |
|--------|--------|
| ![Jan-17-2024
16-03-07](https://github.com/elastic/kibana/assets/8698078/d40993fc-ed16-4ca6-86fa-aa156e4ef4d8)
| ![Jan-17-2024
16-04-00](https://github.com/elastic/kibana/assets/8698078/1746cecb-8c93-46a9-b381-1ef07b1d9999)
|

### Checklist

- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@Heenawter @CoenWarmer
[Controls] Fix text alignment of options list control selections (ela…
462d4ad 
…stic#175073)

Closes elastic#174971

## Summary

This PR fixes the alignment issue for the options list control that
happened due to the most recent EUI update.

| Before | After |
|--------|--------|
| ![Jan-17-2024
16-03-07](https://github.com/elastic/kibana/assets/8698078/d40993fc-ed16-4ca6-86fa-aa156e4ef4d8)
| ![Jan-17-2024
16-04-00](https://github.com/elastic/kibana/assets/8698078/1746cecb-8c93-46a9-b381-1ef07b1d9999)
|

### Checklist

- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@Heenawter @fkanout
[Controls] Fix text alignment of options list control selections (ela…
a8d3094 
…stic#175073)

Closes elastic#174971

## Summary

This PR fixes the alignment issue for the options list control that
happened due to the most recent EUI update.

| Before | After |
|--------|--------|
| ![Jan-17-2024
16-03-07](https://github.com/elastic/kibana/assets/8698078/d40993fc-ed16-4ca6-86fa-aa156e4ef4d8)
| ![Jan-17-2024
16-04-00](https://github.com/elastic/kibana/assets/8698078/1746cecb-8c93-46a9-b381-1ef07b1d9999)
|

### Checklist

- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees

@Heenawter Heenawter

Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Controls release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Controls] Options list control selections are centered
6 participants
@Heenawter @elasticmachine @kibana-ci @nreese @ryankeairns @kibanamachine