Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated data plugin references #175120

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Remove deprecated data plugin references #175120

merged 3 commits into from
Jan 23, 2024

Conversation

thomheymann
Copy link
Contributor

@thomheymann thomheymann commented Jan 18, 2024 •
edited
Loading

Resolves #124107
Related meta issue part #124063

Summary

Replace usages of deprecated index pattern service and related types

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@thomheymann thomheymann added Team:obs-ux-logs Observability Logs User Experience Team release_note:skip Skip the PR/issue when compiling release notes labels Jan 18, 2024
@thomheymann
Copy link
Contributor Author

/ci

1 similar comment
@thomheymann
Copy link
Contributor Author

/ci

@thomheymann thomheymann marked this pull request as ready for review January 22, 2024 09:15
@thomheymann thomheymann requested review from a team as code owners January 22, 2024 09:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

tonyghiani
tonyghiani approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only LGTM.

jennypavlova
jennypavlova approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra code changes LGTM 🚀

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group5.ts / discover/group1 "after all" hook: unloadMakelogs in "discover/group1"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.3MB 1.3MB -11.0B
Unknown metric groups

References to deprecated APIs

id before after diff
infra 8 7 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomheymann thomheymann merged commit 450c384 into elastic:main Jan 23, 2024
17 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 23, 2024
lcawl pushed a commit to lcawl/kibana that referenced this pull request Jan 26, 2024
@thomheymann @lcawl
Remove deprecated data plugin references (elastic#175120)
799ac26 
Resolves elastic#124107
Related meta issue part elastic#124063

## Summary

Replace usages of deprecated index pattern service and related types
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@thomheymann @CoenWarmer
Remove deprecated data plugin references (elastic#175120)
5286c30 
Resolves elastic#124107
Related meta issue part elastic#124063

## Summary

Replace usages of deprecated index pattern service and related types
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@thomheymann @CoenWarmer
Remove deprecated data plugin references (elastic#175120)
06057fd 
Resolves elastic#124107
Related meta issue part elastic#124063

## Summary

Replace usages of deprecated index pattern service and related types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennypavlova jennypavlova jennypavlova approved these changes

@tonyghiani tonyghiani tonyghiani approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra UI] Replace usages of deprecated index pattern service and related types
7 participants
@thomheymann @apmmachine @elasticmachine @kibana-ci @jennypavlova @tonyghiani @kibanamachine