Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Anomaly Detection: Adds actions menu to anomaly markers in Single Metric Viewer chart. #175556

Merged
merged 14 commits into from
Feb 6, 2024
Merged

[ML] Anomaly Detection: Adds actions menu to anomaly markers in Single Metric Viewer chart. #175556

merged 14 commits into from
Feb 6, 2024

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Jan 25, 2024 •
edited
Loading

Summary

  • Adds the actions menu that's available in the anomaly table to anomaly markers in Single Metric Viewer chart.
  • Adds functional tests for the existing functionality to test the action link from the anomaly table to Discover as well as the new popover on anomaly markers in the Single Metric Viewer chart.
ml-ad-smv-click-0002.webm

Checklist

@walterra walterra self-assigned this Jan 25, 2024
@walterra walterra mentioned this pull request Jan 25, 2024
Closed
11 tasks
@walterra walterra force-pushed the ml-ad-smv-anomaly-click-action branch from 4d18755 to ed1ed50 Compare January 31, 2024 08:33
@walterra walterra force-pushed the ml-ad-smv-anomaly-click-action branch from ed1ed50 to 7ece42a Compare February 2, 2024 13:22
@walterra walterra marked this pull request as ready for review February 2, 2024 13:24
@walterra walterra requested a review from a team as a code owner February 2, 2024 13:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest changes and LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.6MB 3.6MB +2.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

alvarezmelissa87
alvarezmelissa87 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@walterra walterra merged commit fc38ad8 into elastic:main Feb 6, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 6, 2024
@walterra walterra deleted the ml-ad-smv-anomaly-click-action branch February 6, 2024 16:51
jloleysens added a commit that referenced this pull request Feb 7, 2024
@jloleysens
Merge branch 'main' into versioned-router-and-oas
32ba707 
* main: (224 commits)
  [Http] Replace `buildNr` with `buildSha` in static asset paths (#175898)
  [Ops] Fix GCS bucket access for future buildkite agents (#174756)
  [api-docs] 2024-02-07 Daily api_docs build (#176362)
  skip flaky suite (#176002)
  skip failing es promotion suite (#176359)
  [Cloud Security] [Grouping] Add URL Params support to the grouping components (#175749)
  chore(NA): update versions after v8.12.2 bump (#176309)
  chore(NA): update versions after v7.17.19 bump (#176313)
  skip failing test suite (#176352)
  [SLO] Enable burn rate alert by default during creation via UI (#176317)
  [Fleet] Add the uptime capability to observability projects (#176285)
  [Security Solution][Endpoint] Fix Manifest Manger so that it works with large (>10k) (#174411)
  [ResponseOps] Alert creation delay based on user definition (#175851)
  [data views] Default field formatters based on field meta values (#174973)
  [Cloud Security]Detection Rules counter on Rules Flyout (#176041)
  [Security Solution] Data Quality Dashboard persistence (#175673)
  [Ent Search] Connector client copy cleanup (#176290)
  [ML] Anomaly Detection: Adds actions menu to anomaly markers in Single Metric Viewer chart. (#175556)
  [ML] Anomaly Detection: Fix `values-dots` colors (#176303)
  [Fleet] Logstash Output - being compliant to RFC-952 (#176298)
  ...
fkanout pushed a commit to fkanout/kibana that referenced this pull request Feb 7, 2024
@walterra @fkanout
[ML] Anomaly Detection: Adds actions menu to anomaly markers in Singl…
35eb470 
…e Metric Viewer chart. (elastic#175556)

## Summary

- Adds the actions menu that's available in the anomaly table to anomaly
markers in Single Metric Viewer chart.
- Adds functional tests for the existing functionality to test the
action link from the anomaly table to Discover as well as the new
popover on anomaly markers in the Single Metric Viewer chart.


[ml-ad-smv-click-0002.webm](https://github.com/elastic/kibana/assets/230104/ff8e6c64-65a2-4557-8ed7-ba8e029642a5)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@walterra walterra mentioned this pull request Feb 7, 2024
Merged
9 tasks
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@walterra @CoenWarmer
[ML] Anomaly Detection: Adds actions menu to anomaly markers in Singl…
6e76b67 
…e Metric Viewer chart. (elastic#175556)

## Summary

- Adds the actions menu that's available in the anomaly table to anomaly
markers in Single Metric Viewer chart.
- Adds functional tests for the existing functionality to test the
action link from the anomaly table to Discover as well as the new
popover on anomaly markers in the Single Metric Viewer chart.


[ml-ad-smv-click-0002.webm](https://github.com/elastic/kibana/assets/230104/ff8e6c64-65a2-4557-8ed7-ba8e029642a5)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@walterra @CoenWarmer
[ML] Anomaly Detection: Adds actions menu to anomaly markers in Singl…
17195d4 
…e Metric Viewer chart. (elastic#175556)

## Summary

- Adds the actions menu that's available in the anomaly table to anomaly
markers in Single Metric Viewer chart.
- Adds functional tests for the existing functionality to test the
action link from the anomaly table to Discover as well as the new
popover on anomaly markers in the Single Metric Viewer chart.


[ml-ad-smv-click-0002.webm](https://github.com/elastic/kibana/assets/230104/ff8e6c64-65a2-4557-8ed7-ba8e029642a5)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@walterra walterra mentioned this pull request Feb 19, 2024
Merged
2 tasks
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@walterra @fkanout
[ML] Anomaly Detection: Adds actions menu to anomaly markers in Singl…
78039c4 
…e Metric Viewer chart. (elastic#175556)

## Summary

- Adds the actions menu that's available in the anomaly table to anomaly
markers in Single Metric Viewer chart.
- Adds functional tests for the existing functionality to test the
action link from the anomaly table to Discover as well as the new
popover on anomaly markers in the Single Metric Viewer chart.


[ml-ad-smv-click-0002.webm](https://github.com/elastic/kibana/assets/230104/ff8e6c64-65a2-4557-8ed7-ba8e029642a5)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
walterra added a commit that referenced this pull request Mar 5, 2024
@walterra
[ML] Anomaly Detection: Fix anomaly marker click in Single Metric Vie…
dda8c8f 
…wer embeddable (#176788)

## Summary

Part of #176651 and #153476. Follow up to #175556.

Fixes the click on anomaly markers in the Single Metric Viewer
embeddable. This required refactoring some dependencies to be properly
passed in via React contexts instead of the legacy dependency cache.

[smv-embeddable-click-0001.webm](https://github.com/elastic/kibana/assets/230104/6d0bb0e5-bfde-4429-8876-bdc94ce646c8)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@walterra walterra mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:enhancement v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @kibana-ci @alvarezmelissa87 @peteharverson @kibanamachine