-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Anomaly Detection: Adds single metric viewer embeddable for dashboards #175857
Merged
alvarezmelissa87
merged 20 commits into
elastic:main
from
alvarezmelissa87:ml-ad-single-metric-embeddable
Feb 8, 2024
Merged
Changes from 6 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c144d04
wip: create single metric viewer action in dashboard
alvarezmelissa87 a272e21
wip: add smv as embeddable that can be viewed in dashboards
alvarezmelissa87 4cae098
fix multiple charts issue
alvarezmelissa87 978f019
fix slider listener for multiple smv charts
alvarezmelissa87 8333406
remove unnecessary comments
alvarezmelissa87 efce040
add unique id to checkbox
alvarezmelissa87 e2e9388
fix entity selection controls
alvarezmelissa87 d931543
ensure panel settings are applied
alvarezmelissa87 c5304be
remove annototaion creation when embeddable
alvarezmelissa87 85d0042
remove annotations help text for embeddable
alvarezmelissa87 a744275
ensure type is correct
alvarezmelissa87 c5181f1
remove unnecessary services from context
alvarezmelissa87 ba542f1
Merge branch 'main' into ml-ad-single-metric-embeddable
kibanamachine 9078703
fix translations
alvarezmelissa87 f682daa
update naming
alvarezmelissa87 4b514c3
fix metric jobs in SMV in dashboard and ML
alvarezmelissa87 659f1ca
update naming from provider to factory for consistency
alvarezmelissa87 8dedbde
Merge branch 'main' into ml-ad-single-metric-embeddable
kibanamachine 39988a0
Merge branch 'main' into ml-ad-single-metric-embeddable
kibanamachine 1bd6b8b
add comment to consolidate all duplicated services
alvarezmelissa87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
x-pack/plugins/ml/public/application/services/field_format_service_provider.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { type MlFieldFormatService, FieldFormatService } from './field_format_service'; | ||
import type { MlIndexUtils } from '../util/index_utils_provider'; | ||
import type { MlApiServices } from './ml_api_service'; | ||
|
||
export function fieldFormatServiceProvider( | ||
walterra marked this conversation as resolved.
Show resolved
Hide resolved
|
||
mlApiServices: MlApiServices, | ||
mlIndexUtils: MlIndexUtils | ||
): MlFieldFormatService { | ||
return new FieldFormatService(mlApiServices, mlIndexUtils); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we can probably get rid of this
mlUtilsService
and instantiate the providers formlTimeBuckets
andmlTimeSeriesExplorer
inside the react classes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in c5181f1