[Discover] Support grid column settings on Surrounding Documents page #177003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
release_note:fix
Team:DataDiscovery
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
jughosta
changed the title
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @jughosta |
kertal
approved these changes
Feb 19, 2024
|
@kertal I updated the PR description. Is it what you meant? |
|
@jughosta yes, excactly, thx 👍 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 19, 2024
…elastic#177003) - Closes elastic#174485 ### Summary This PR keeps track of column resizing on Surrounding documents page: if user resizes columns and thne loads more documents, the grid will rerender accordingly and it will keep custom column widths. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a482a7a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 19, 2024
…ts page (#177003) (#177231) # Backport This will backport the following commits from `main` to `8.13`: - [[Discover] Support grid column settings on Surrounding Documents page (#177003)](#177003) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-02-19T18:56:05Z","message":"[Discover] Support grid column settings on Surrounding Documents page (#177003)\n\n- Closes https://github.com/elastic/kibana/issues/174485\r\n\r\n### Summary\r\n\r\nThis PR keeps track of column resizing on Surrounding documents page: if\r\nuser resizes columns and thne loads more documents, the grid will\r\nrerender accordingly and it will keep custom column widths.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a482a7a98fc16a4efad27eac38dd67eafe4b64a6","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:DataDiscovery","backport:prev-minor","v8.14.0"],"title":"[Discover] Support grid column settings on Surrounding Documents page","number":177003,"url":"https://github.com/elastic/kibana/pull/177003","mergeCommit":{"message":"[Discover] Support grid column settings on Surrounding Documents page (#177003)\n\n- Closes https://github.com/elastic/kibana/issues/174485\r\n\r\n### Summary\r\n\r\nThis PR keeps track of column resizing on Surrounding documents page: if\r\nuser resizes columns and thne loads more documents, the grid will\r\nrerender accordingly and it will keep custom column widths.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a482a7a98fc16a4efad27eac38dd67eafe4b64a6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177003","number":177003,"mergeCommit":{"message":"[Discover] Support grid column settings on Surrounding Documents page (#177003)\n\n- Closes https://github.com/elastic/kibana/issues/174485\r\n\r\n### Summary\r\n\r\nThis PR keeps track of column resizing on Surrounding documents page: if\r\nuser resizes columns and thne loads more documents, the grid will\r\nrerender accordingly and it will keep custom column widths.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a482a7a98fc16a4efad27eac38dd67eafe4b64a6"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…elastic#177003) - Closes elastic#174485 ### Summary This PR keeps track of column resizing on Surrounding documents page: if user resizes columns and thne loads more documents, the grid will rerender accordingly and it will keep custom column widths. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR keeps track of column resizing on Surrounding documents page: if user resizes columns and thne loads more documents, the grid will rerender accordingly and it will keep custom column widths.
Checklist