[8.13] [Security Solution] Fix rule filters on the Rule Details page (#177081) #177242
+101
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c#177081) **Fixes: elastic#141458 **Fixes: elastic#176866 ## Summary Fixes the bugs above by changing the `Filters` component: - from using lower-level components like `FilterBadgeGroup` and custom rendering - to using a higher-level `FilterItems` component that's used inside a larger component `QueryBar` (see the first screenshot below) on the Rule Creation / Editing pages Note that for some reason the end result still does not fully equal to how filters look on the Rule Creation / Editing pages, where there are fewer warnings. It's hard to say which rendering is the right one. ## Screenshots **How filters look on the Rule Creation / Editing pages:** <img width="989" alt="Screenshot 2024-02-15 at 21 25 00" src="https://github.com/elastic/kibana/assets/7359339/01ca468f-be99-469a-8d75-ee5aa1a31fb0"> **Rule Details page BEFORE the fix:** <img width="1792" alt="Screenshot 2024-02-15 at 21 23 46" src="https://github.com/elastic/kibana/assets/7359339/d0e2aa6e-3050-4327-8025-f37125498fd6"> <img width="1792" alt="Screenshot 2024-02-15 at 21 24 02" src="https://github.com/elastic/kibana/assets/7359339/a89302b2-f991-4547-bdac-c0f5a594a881"> <img width="1792" alt="Screenshot 2024-02-15 at 21 24 18" src="https://github.com/elastic/kibana/assets/7359339/49c16b02-8d82-4f93-932f-3846880a0457"> **Rule Details page AFTER the fix 1 (filters use non-existing fields and show warnings):** <img width="1790" alt="Screenshot 2024-02-15 at 21 28 46" src="https://github.com/elastic/kibana/assets/7359339/e229b4ff-6ee7-4444-b5c1-deb00d2b9b39"> **Rule Details page AFTER the fix 2 (filters use existing fields and look normal):** <img width="1792" alt="Screenshot 2024-02-15 at 21 37 45" src="https://github.com/elastic/kibana/assets/7359339/b10905e7-803d-4404-aa02-8692ff964891"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 2672662)
6 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: cc @banderror |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.13:Questions ?
Please refer to the Backport tool documentation