[Synthetics] Fixes pending count filtering #177499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:skip
botelastic
bot
added
the
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
justinkambic
approved these changes
Feb 21, 2024
| @@ -51,24 +51,30 @@ export function OverviewStatus() { | |||
| pending: 0, | |||
There was a problem hiding this comment.
I honestly think this switch deserves to be a separate function call, this useEffect callback is yuge.
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 21, 2024
## Summary Fixes pending count filtering !! Follow up to elastic#177406 <img width="1728" alt="image" src="https://github.com/elastic/kibana/assets/3505601/3dea1684-d6a9-44ab-b9a7-ad6c60079542"> (cherry picked from commit 1f8bfae)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 21, 2024
## Summary Fixes pending count filtering !! Follow up to elastic#177406 <img width="1728" alt="image" src="https://github.com/elastic/kibana/assets/3505601/3dea1684-d6a9-44ab-b9a7-ad6c60079542"> (cherry picked from commit 1f8bfae)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 21, 2024
# Backport This will backport the following commits from `main` to `8.13`: - [[Synthetics] Fixes pending count filtering (#177499)](#177499) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-02-21T19:25:57Z","message":"[Synthetics] Fixes pending count filtering (#177499)\n\n## Summary\r\n\r\nFixes pending count filtering !!\r\n\r\nFollow up to https://github.com/elastic/kibana/pull/177406\r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3505601/3dea1684-d6a9-44ab-b9a7-ad6c60079542\">","sha":"1f8bfae21c14c5d4dfe259691e9f71b366cdfc92","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","Team:obs-ux-infra_services","v8.13.0","v8.12.2","v8.14.0"],"title":"[Synthetics] Fixes pending count filtering","number":177499,"url":"https://github.com/elastic/kibana/pull/177499","mergeCommit":{"message":"[Synthetics] Fixes pending count filtering (#177499)\n\n## Summary\r\n\r\nFixes pending count filtering !!\r\n\r\nFollow up to https://github.com/elastic/kibana/pull/177406\r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3505601/3dea1684-d6a9-44ab-b9a7-ad6c60079542\">","sha":"1f8bfae21c14c5d4dfe259691e9f71b366cdfc92"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","8.12"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.12","label":"v8.12.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177499","number":177499,"mergeCommit":{"message":"[Synthetics] Fixes pending count filtering (#177499)\n\n## Summary\r\n\r\nFixes pending count filtering !!\r\n\r\nFollow up to https://github.com/elastic/kibana/pull/177406\r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3505601/3dea1684-d6a9-44ab-b9a7-ad6c60079542\">","sha":"1f8bfae21c14c5d4dfe259691e9f71b366cdfc92"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 21, 2024
# Backport This will backport the following commits from `main` to `8.12`: - [[Synthetics] Fixes pending count filtering (#177499)](#177499) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-02-21T19:25:57Z","message":"[Synthetics] Fixes pending count filtering (#177499)\n\n## Summary\r\n\r\nFixes pending count filtering !!\r\n\r\nFollow up to https://github.com/elastic/kibana/pull/177406\r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3505601/3dea1684-d6a9-44ab-b9a7-ad6c60079542\">","sha":"1f8bfae21c14c5d4dfe259691e9f71b366cdfc92","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","Team:obs-ux-infra_services","v8.13.0","v8.12.2","v8.14.0"],"title":"[Synthetics] Fixes pending count filtering","number":177499,"url":"https://github.com/elastic/kibana/pull/177499","mergeCommit":{"message":"[Synthetics] Fixes pending count filtering (#177499)\n\n## Summary\r\n\r\nFixes pending count filtering !!\r\n\r\nFollow up to https://github.com/elastic/kibana/pull/177406\r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3505601/3dea1684-d6a9-44ab-b9a7-ad6c60079542\">","sha":"1f8bfae21c14c5d4dfe259691e9f71b366cdfc92"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","8.12"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.12","label":"v8.12.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177499","number":177499,"mergeCommit":{"message":"[Synthetics] Fixes pending count filtering (#177499)\n\n## Summary\r\n\r\nFixes pending count filtering !!\r\n\r\nFollow up to https://github.com/elastic/kibana/pull/177406\r\n\r\n<img width=\"1728\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3505601/3dea1684-d6a9-44ab-b9a7-ad6c60079542\">","sha":"1f8bfae21c14c5d4dfe259691e9f71b366cdfc92"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
|
This PR didn't landed on time to be included on v8.12.2. Updating the labels. |
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary Fixes pending count filtering !! Follow up to elastic#177406 <img width="1728" alt="image" src="https://github.com/elastic/kibana/assets/3505601/3dea1684-d6a9-44ab-b9a7-ad6c60079542">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes pending count filtering !!
Follow up to #177406