Correct custom threshold order in the rule list #179244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryam-saeidi
added
the
release_note:skip
botelastic
bot
added
the
Team:obs-ux-management
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
fkanout
reviewed
Mar 22, 2024
| @@ -116,6 +116,6 @@ export const registerObservabilityRuleTypes = async ( | |||
| '../components/custom_threshold/components/alert_details_app_section/alert_details_app_section' | |||
| ) | |||
| ), | |||
| priority: 5, | |||
| priority: 110, | |||
There was a problem hiding this comment.
@maryam-saeidi, is this the same order in the serverless? Because I remember I saw the rule in a different order on serverless
There was a problem hiding this comment.
No, for some reason in serverless, the order is alphabetical.
fkanout
approved these changes
Mar 22, 2024
💚 Build Succeeded
Metrics [docs]Page load bundle
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.14.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the custom threshold is now GA, I changed the order based on the original plan mentioned here.