Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rules > Add Elastic rules][SCREEN READER]: Headings must be properly nested for usability #180358

Merged
merged 5 commits into from
Apr 12, 2024
Merged

[Rules > Add Elastic rules][SCREEN READER]: Headings must be properly nested for usability #180358

merged 5 commits into from
Apr 12, 2024

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Apr 9, 2024 •
edited
Loading

Closes: https://github.com/elastic/security-team/issues/8653

Description

The Add Elastic Rules empty prompt (all rules added) has an H3 improperly nested. This makes for a more difficult screen reader experience; a large number of screen reader users primarily navigate by headings.

Steps to recreate

  1. Open Add Elastic rules
  2. Add all rules to the monitoring table if not already
  3. Open HeadingsMap extension or your preferred screen reader
  4. If using a screen reader, traverse the page by headings only to hear the perceived importance of information

Screen

image

@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management Team:Detection Rule Management Security Detection Rule Management Team v8.14.0 labels Apr 9, 2024
@alexwizp alexwizp marked this pull request as ready for review April 9, 2024 11:20
@alexwizp alexwizp requested a review from a team as a code owner April 9, 2024 11:20
@alexwizp alexwizp requested a review from jpdjere April 9, 2024 11:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@banderror banderror added Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules Team:Detections and Resp Security Detection Response Team and removed Feature:Rule Management Security Solution Detection Rule Management labels Apr 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jpdjere
jpdjere approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@jpdjere jpdjere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this - LGTM 🎉

@alexwizp alexwizp merged commit 19acf2a into elastic:main Apr 12, 2024
34 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdjere jpdjere jpdjere approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexwizp @elasticmachine @kibana-ci @jpdjere @banderror @kibanamachine