Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console Monaco Migration] Add autosave to localStorage #180620

Merged

Conversation

ElenaStoeva
Copy link
Contributor

Closes #180211

Summary

This PR adds support for autosaving the current Console editor value to local storage.

How to test:

  1. Create a config/kibana.dev.yml file (if one doesn't exist already) and add the line: console.dev.enableMonaco: true
  2. Start Es and Kibana
  3. Go to Dev Tools -> Console
  4. Type in some input in Console
  5. Navigate to another page and come back to Console. Verify that the input is the same as the one you last typed.

@ElenaStoeva ElenaStoeva added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes labels Apr 11, 2024
@ElenaStoeva ElenaStoeva self-assigned this Apr 11, 2024
@ElenaStoeva
Copy link
Contributor Author

/ci

@ElenaStoeva ElenaStoeva marked this pull request as ready for review April 11, 2024 17:03
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner April 11, 2024 17:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this functionality, @ElenaStoeva!
I tested locally to confirm that the value is saved to the localStorage

@ElenaStoeva ElenaStoeva enabled auto-merge (squash) April 15, 2024 18:55
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
console 241 242 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 434.0KB 434.3KB +244.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

@ElenaStoeva ElenaStoeva merged commit 46111c9 into elastic:main Apr 15, 2024
16 checks passed
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Apr 15, 2024
@ElenaStoeva ElenaStoeva deleted the console-monaco-migration/add-autosave branch June 24, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Console Monaco migration] Autosave to localStorage
5 participants